Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested runme (running runme as part of a cell/block) garbles init sequence #495

Open
sourishkrout opened this issue Feb 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@sourishkrout
Copy link
Member

sourishkrout commented Feb 12, 2024

Running $ runme --filename garble.md run garble inside of https://github.com/stateful/vscode-runme with following markdown produces output with the runme init sequence garbled (screenshot below).

---
runme:
  id: 01HPF9RK4ANXWGH3DRF4SV7CZR
  version: v2.2
---

```sh {"id":"01HPF9RNHT3RSAGWA4CR4HKRS8","name":"garble"}
npx runme run test:format test:lint test:lint:fix
```

Visual problem:
image

@sourishkrout
Copy link
Member Author

@adambabik is it safe to assume that above's issue will be fixed by completing the switch to runnerv2 (#474)?

@sourishkrout sourishkrout added the bug Something isn't working label Feb 12, 2024
@adambabik
Copy link
Collaborator

I tested it quickly and it looks ok with run-locally. I think you can test it yourself:

# in /path/to/github.com/stateful/vscode-runme

$ runme --version
runme version 2.2.6 (Homebrew) on 2024-02-09T17:53:40Z

$ runme --filename CONTRIBUTING.md run-locally test
 ►  Running task test:format...
nvm is not compatible with the "npm_config_prefix" environment variable: currently set to "/usr/local"
Run `unset npm_config_prefix` to unset it.
Checking formatting...
src/client/components/terminal/share.ts

The output of run-locally is not distorted, unlike run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants