Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENR update call does not remove fields that are no longer applicable #639

Open
kdeme opened this issue Sep 22, 2023 · 0 comments
Open

ENR update call does not remove fields that are no longer applicable #639

kdeme opened this issue Sep 22, 2023 · 0 comments
Labels
bug Something isn't working discoveryv5 Discovery v5 related issues

Comments

@kdeme
Copy link
Contributor

kdeme commented Sep 22, 2023

nim-eth/eth/p2p/discoveryv5/enr.nim

Line 279 in f133d7a

func update*(
is flawed in the sense that old fieldPairs that are no longer in the new fieldPairs don't get removed. The update basically only works in 1 direction.
@kdeme kdeme added discoveryv5 Discovery v5 related issues bug Something isn't working labels Sep 22, 2023
@kdeme kdeme mentioned this issue Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working discoveryv5 Discovery v5 related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdeme