Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority for static routes #117

Open
Leobaillard opened this issue Oct 11, 2019 · 2 comments
Open

Priority for static routes #117

Leobaillard opened this issue Oct 11, 2019 · 2 comments

Comments

@Leobaillard
Copy link

Hi!

Thanks for this very useful plugin!

While setting up my static pages, I realized that the default priority for this provider is 0.3. That seemed a bit low to me, especially for instance in the case of a home page.

Would it be possible to leave 0.3 as a default and allow customizing the priority per route in the configuration?

Thanks!

@stefandoorn
Copy link
Owner

Hi @Leobaillard! Yes, that would be a nice feature, to have this configurable. Either via the config and/or service declaration, or via a public method in the provider.. I'm not sure what is the best way yet, but I'm open to a PR with a nice solution. Would you be able to provide a PR?

@Leobaillard
Copy link
Author

I would indeed. In fact, I've already implemented a working solution in a fork. I'll create a PR from that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants