Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

[epic] migrate Soroban Docs into Stellar Docs #740

Closed
17 of 19 tasks
ElliotFriend opened this issue Feb 21, 2024 · 8 comments
Closed
17 of 19 tasks

[epic] migrate Soroban Docs into Stellar Docs #740

ElliotFriend opened this issue Feb 21, 2024 · 8 comments
Assignees

Comments

@ElliotFriend
Copy link
Contributor

ElliotFriend commented Feb 21, 2024

Since the Stellar Mainnet validators have affirmatively voted to upgrade the network to protocol version 20, now we begin the task of combining this documentation repository and the stellar/stellar-docs repository.

This issue will serve to track all the work needed to move content, as well as redirect where necessary.

The general process will be:

  1. We'll create a PR in the stellar-docs repo that serves to put the content of a section of documentation from this repo into the new one.
  2. A corresponding PR will be made in the soroban-docs repo that will redirect URLs and remove content (where applicable) from this repo.

Once that PR is ready, rinse and repeat. Several of these changes may involve merging main back into the feature branch along the way.

Done

In-Progress

@ElliotFriend ElliotFriend self-assigned this Feb 22, 2024
@thisBrian
Copy link

Hi Elliot great work,

I was looking into one of the Todo points you mentioned

  • Research the ideal way to move content while preserving (at least some?) git history

Have you explored using the --allow-unrelated-histories flag? Might be a way to achieve that.

@ElliotFriend
Copy link
Contributor Author

Have you explored using the --allow-unrelated-histories flag? Might be a way to achieve that.

Hi, Brian! Thanks for the suggestion!

I've come across the unrelated histories flag as a probable solution, but haven't yet taken the time to figure out precisely how to use it. Do you have any experience with it? If so, I'd love some pointers.

For a quasi-hypothetical example: Suppose I wanted to take all of the files that are located in the /api directory in the soroban-docs repo and bring it into the stellar-docs repo, maybe into a new directory like /api/soroban-rpc. Is it possible to pick and choose just a single directory to do that with? Or, would I need to do it with the whole working tree? Does it matter that the source/destination directories have different paths from the repo root?

Not that you have to have the answers lol, just tossing out some of the thoughts that have been rattling around in my head.

Thanks again!

@thisBrian
Copy link

Hi Elliot, those are very good questions.

Our team was doing it when migrating to a monorepo but we had additional tooling in place.
I will look into cloning and creating a test repo from the soroban docs -> stellar-docs directory case and see if I can replicate that specific scenario.
Things are a bit busy at the moment but I will make some time around the next couple of days or so to test it out 👍

@overcat
Copy link
Contributor

overcat commented Feb 29, 2024

Hi, if I want to submit a PR to add Java SDK example here, is it better to wait until the migration is completed and then submit it to stellar-docs, or is it better to submit it to this repo now?

@ElliotFriend
Copy link
Contributor Author

Things are a bit busy at the moment but I will make some time around the next couple of days or so to test it out 👍

@thisBrian I actually did some toying around with it yesterday, and I think i did reasonably well with the soroban-rpc stuff. It's on this PR: stellar/stellar-docs#325 I found a couple people posting guides for similar stuff online, but I don't exactly recall which ones I used. I'll try to write down a "post-mortem" for how I did it (for future reference) today or tomorrow.

... is it better to wait until the migration is completed and then submit it to stellar-docs, or is it better to submit it to this repo now?

@overcat Is your Java example, already written and just "looking for a home" or will it need some time and iteration? My gut says go ahead and submit it here. We could target the soroban-internals section for the week of March 11 perhaps? Would that be enough time?

@overcat
Copy link
Contributor

overcat commented Mar 8, 2024

@overcat Is your Java example, already written and just "looking for a home" or will it need some time and iteration? My gut says go ahead and submit it here. We could target the soroban-internals section for the week of March 11 perhaps? Would that be enough time?

We have already submitted and merged it.

@gabrieladeniji
Copy link

Hi, was not able to access this page again.

After the merging, would the page be moved to another path, or would still be accessible here?

https://developers.stellar.org/docs/anchoring-assets/anchor-platform/sep24/integration?q=anchoring+assets+anchor+platform+sep24+integration

Screenshot 2024-03-08 at 10 07 50 AM

@briwylde08
Copy link
Contributor

Hi there! That page should be available here: https://developers.stellar.org/network/anchor-platform/admin-guide/sep24/integration

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants