Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document consensus expectations around closeTime #509

Closed
marta-lokhova opened this issue Apr 18, 2024 · 6 comments · Fixed by #572
Closed

Document consensus expectations around closeTime #509

marta-lokhova opened this issue Apr 18, 2024 · 6 comments · Fixed by #572
Assignees
@marta-lokhova

Comments

@marta-lokhova
Copy link
Contributor

Add more detail about accuracy of timestamps produced by consensus
@marta-lokhova marta-lokhova self-assigned this Apr 18, 2024
@tomerweller tomerweller mentioned this issue Apr 18, 2024
Closed
janewang pushed a commit that referenced this issue Apr 23, 2024
Update accuracy of ledger closeTime timestamp in ledger header and close
5dd381b 
 #509
@janewang janewang mentioned this issue Apr 23, 2024
Merged
@marta-lokhova
Copy link
Contributor Author

Hi @janewang, thanks for the PR! I think it'd be great to clarify expectations on accuracy of close time (I should have linked the original discussion that prompted this issue: https://stellarfoundation.slack.com/archives/C9H5JTW1J/p1713392041720139). Close time is selected by individual validators during voting, so it might be slightly inaccurate depending if the clock on the validator has drifted. There is also a specific "validity window" that validators use to validate close time from other nodes, that I think is worth documenting.

@marta-lokhova marta-lokhova reopened this Apr 23, 2024
@janewang
Copy link
Contributor

janewang commented Apr 23, 2024 •
edited
Loading

@marta-lokhova Would you be able to take over this ticket and add the information described to our docs?

It was not clear from the ticket that validity window is being discussed, nor was the slack thread being referenced in the ticket. This is an issue the docs team is currently struggling with with tickets missing descriptions.

I think it would be good if engineers get into the habit of update the docs as it's currently unsustainable that a group of 2 people update the docs for all moving parts of open source network development.

@marta-lokhova
Copy link
Contributor Author

Of course, I wasn't expecting you guys to deal with it (hence I assigned it to myself)

@janewang
Copy link
Contributor

janewang commented May 7, 2024

@marta-lokhova Are you able to work on this for us? Thanks in advance!

@janewang
Copy link
Contributor

@marta-lokhova Are you able to assist with closing this one?

@marta-lokhova
Copy link
Contributor Author

Hi @janewang, I'm planning to work on this in this sprint.

@marta-lokhova marta-lokhova mentioned this issue May 15, 2024
Merged
@leighmcculloch leighmcculloch mentioned this issue Jul 11, 2024
Merged
github-merge-queue bot pushed a commit to stellar/rs-soroban-sdk that referenced this issue Jul 16, 2024
@leighmcculloch
Document the accuracy of the ledger timestamp (#1289)
1f10e9a 
### What
Document the accuracy of the ledger timestamp.

### Why
It's important that the accuracy is known by developers relying on the
timestamp for certain use cases. The update here is taken from a recent
update in the Stellar docs and communicates the same.

Related stellar/stellar-docs#509
Related stellar/stellar-docs#572

Close #1258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marta-lokhova marta-lokhova

Labels
None yet
Projects
Dev Docs
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a note about accuracy of close time marta-lokhova/stellar-docs
2 participants
@janewang @marta-lokhova