Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: Replace internal BufReader used in iterator with lightweight Read impl #103

Open
leighmcculloch opened this issue Jun 22, 2022 · 0 comments

Comments

@leighmcculloch
Copy link
Member

The iterator in the Rust uses a BufReader out of convenience as a method for peeking for an EOF, but it is particularly inefficient, especially if the user is already using a BufReader. The only reason we need it is to peek for an EOF. We should find another way to do that with a custom Read impl.

This is a follow up to #102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant