Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation rules for database names is possibly wrong #429

Open
karlskidmore opened this issue Apr 14, 2019 · 0 comments
Open

Validation rules for database names is possibly wrong #429

karlskidmore opened this issue Apr 14, 2019 · 0 comments

Comments

@karlskidmore
Copy link

Validation rules for database names is possibly wrong (at least for PostgreSQL DBs). Valid names cannot have dashes but can have underscores, but as we can see here:

Name string `yaml:"name,omitempty" validate:"validateLeadingAlphaNumericDash"`
we're specifying the validateLeadingAlphaNumericDash rule, which would allow invalid PostgreSQL database names while prevent use of valid names that used an underscore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant