Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Incorrectly assuming the custom elements dir #2

Open
sean-perkins opened this issue Feb 6, 2024 · 0 comments
Open

bug: Incorrectly assuming the custom elements dir #2

sean-perkins opened this issue Feb 6, 2024 · 0 comments
Labels
type: bug a confirmed bug report

Comments

@sean-perkins
Copy link
Collaborator

Currently the custom elements directory if not specified explicitly in the stencil.config.ts is inferred as dist/components: https://github.com/stencil-community/stencil-react-output-target/blob/ce410fed12552d65fe0884146f018c0070bcc902/packages/react-output-target/src/index.ts#L20C33-L20C43.

However, developers are not publishing their UI kits from the root. They are publishing from the dist/ directory or similar output path. The detection for the path needs to include this assumption or allow easier configuration to assign the path.

@sean-perkins sean-perkins changed the title Incorrectly assuming the custom elements dir bug: Incorrectly assuming the custom elements dir Feb 6, 2024
@sean-perkins sean-perkins added the type: bug a confirmed bug report label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

1 participant