bug: type definition of h() function does not match implementation.

[trusktr]

Prerequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Stencil Version

4.26.0

Current Behavior

The type definition of the h() function does match the runtime definition.

Expected Behavior

Expect the types to match.

System Info

n/a

Steps to Reproduce

Look at the implementation:

core/src/runtime/vdom/h.ts

Line 18 in 03a5ff9

export const h = (nodeName: any, vnodeData: any, ...children: d.ChildType[]): d.VNode => {

Look at the type definition users see:

core/src/declarations/stencil-public-runtime.ts

Lines 630 to 637 in 03a5ff9

	export declare function h(sel: any): VNode;
	export declare function h(sel: Node, data: VNodeData | null): VNode;
	export declare function h(sel: any, data: VNodeData | null): VNode;
	export declare function h(sel: any, text: string): VNode;
	export declare function h(sel: any, children: Array<VNode | undefined | null>): VNode;
	export declare function h(sel: any, data: VNodeData | null, text: string): VNode;
	export declare function h(sel: any, data: VNodeData | null, children: Array<VNode | undefined | null>): VNode;
	export declare function h(sel: any, data: VNodeData | null, children: VNode): VNode;

Code Reproduction URL

Example:

import {h} from '@stencil/core';

const test1 = h('div', { id: 'foo' },
  'bar',





  h('img', { src: 'foo.png' }),
  h('span', { id: 'bar' },
    h('img', { src: 'bar.png' })),
);

Result:

Additional Information

Looks like the type definition exported publicly is hand-written, and not derived from the actual types of the implementation.

For example, the implementation accepts ...children but the public type definition does not.

[christian-bromann]

Thanks for raising this issue. I do not have enough historical context to know why we have different definitions for this. I am open to suggestions. Any contributions are much appreciated.