Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests #28

Open
j7nn7k opened this issue Dec 30, 2015 · 5 comments
Open

Tests #28

j7nn7k opened this issue Dec 30, 2015 · 5 comments

Comments

@j7nn7k
Copy link
Contributor

j7nn7k commented Dec 30, 2015

The docs mention tests. Are there any? If not, do you have any preferred testing framework?
@j7nn7k j7nn7k closed this as completed Oct 30, 2016
@j7nn7k
Copy link
Contributor Author

j7nn7k commented Oct 30, 2016

Guess there are none at this point ;)

@stephenmcd
Copy link
Owner

Would you like to add some?

@j7nn7k
Copy link
Contributor Author

j7nn7k commented Oct 31, 2016

Why not

@j7nn7k j7nn7k reopened this Oct 31, 2016
@j7nn7k
Copy link
Contributor Author

j7nn7k commented Oct 31, 2016

@stephenmcd I added some tests. Unfortunately I can't make a pull request from a drum fork because I already maintain a drum fork, which is not fully compatible anymore with the original drum project.

Is there a chance I can push my branch to the original project? Of course in a separate branch!

Thanks
Jannik

@stephenmcd
Copy link
Owner

If you create a branch in your fork that doesn't include your changes, merge this repo's master into it, and add tests there, you should be able to create a valid PR.

j7nn7k pushed a commit to j7nn7k/drum that referenced this issue Nov 1, 2016
@jnkwrych
Add basic form and model tests stephenmcd#28
0e760af
j7nn7k pushed a commit to j7nn7k/drum that referenced this issue Nov 2, 2016
@jnkwrych
Made changes requested in pull request stephenmcd#48 - issue stephenm…
454676c 
…cd#28
stephenmcd added a commit that referenced this issue Nov 3, 2016
@stephenmcd
Merge pull request #48 from j7nn7k/drum-master__tests_issue_28
2a902bf 
Add tests issue #28
tebica pushed a commit to tebica/drum that referenced this issue Jul 3, 2017
@jnkwrych @tebica
Add basic form and model tests stephenmcd#28
0343870
tebica pushed a commit to tebica/drum that referenced this issue Jul 3, 2017
@jnkwrych @tebica
Made changes requested in pull request stephenmcd#48 - issue stephenm…
2269a94 
…cd#28
aaronrahman326 added a commit to aaronrahman326/drum that referenced this issue Mar 25, 2022
@aaronrahman326
Add basic form and model tests stephenmcd/drum#28
44ce3eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenmcd @j7nn7k