returned ps http error codes not aligned with ps doc

[goekay]

as the title says.

@apheleia, can we make the changes in the code, without fearing to break your system?

[schemar]

Just to confirm:
steve returns different HTTP response codes than stated in the docs at http://docs.plugsurfing.com/en/stable ?

Which changes are you referring to? Updating the HTTP response codes of steve? You should definitely do that, if you can. We will have to test the integration then. But in the long run this is definitely the preferred way.

[goekay]

i realized that we return, for example, lots of "Bad requests" in https://github.com/RWTH-i5-IDSG/steve-plugsurfing/blob/master/src/main/java/de/rwth/idsg/steve/extensions/plugsurfing/rest/ResourceImpl.java#L137

which the docs did not define in http://docs.plugsurfing.com/en/stable/calls/session_stop.html#response

there are only "Unauthorized" and "Not found". but, the checks in implementation cover also more ground than what's in the docs. situations like "No such session" or "Session already expired/closed" are not defined.

[schemar]

Then we will update to documentation to include these cases. That information is very valuable to us. It enables us to show proper error messages to our customers.

[goekay]

ok. can you then tell me which http error response codes from the code you will integrate into the docs, and which ones i should change to align with the docs?