Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade in full to pyproject.toml #400

Open
RobertoRoos opened this issue Jul 25, 2024 · 2 comments
Open

Upgrade in full to pyproject.toml #400

RobertoRoos opened this issue Jul 25, 2024 · 2 comments

Comments

@RobertoRoos
Copy link
Contributor

I think it would be good to make full use of the pyproject.toml file and drop the setup.cfg file at least. Ideally I think we would also drop the setup.py file, but that might be hard because of the adslib build.
@RobertoRoos
Copy link
Contributor Author

Tried to get started in https://github.com/RobertoRoos/pyads/tree/feature/pyproject-toml

@RobertoRoos RobertoRoos mentioned this issue Aug 29, 2024
Open
@RobertoRoos
Copy link
Contributor Author

Hm, I've spend some time on this but I haven't managed a perfect result yet. The way pyads gets packaged is mostly a little weird, because it's build only as source distribution while still building the adslib.so library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RobertoRoos