From add65d8c21ff550a519f1fb200840d53bb1eb12b Mon Sep 17 00:00:00 2001
From: mprahl <mprahl@users.noreply.github.com>
Date: Mon, 10 Apr 2023 09:30:48 -0400
Subject: [PATCH] Stop setting the category label on CertificatePolicy objects

This label is not used for anything and it causes the template-sync to
always think the labels are out of sync which causes an update on every
reconcile.

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
---
 controllers/certificatepolicy_controller.go   | 43 -------------------
 .../certificatepolicy_controller_test.go      | 29 -------------
 2 files changed, 72 deletions(-)

diff --git a/controllers/certificatepolicy_controller.go b/controllers/certificatepolicy_controller.go
index a3286cbb..9fa5fd2d 100644
--- a/controllers/certificatepolicy_controller.go
+++ b/controllers/certificatepolicy_controller.go
@@ -38,7 +38,6 @@ import (
 const (
 	certNameLabel        = "certificate-name"
 	certManagerNameLabel = "certmanager.k8s.io/certificate-name"
-	grcCategory          = "system-and-information-integrity"
 	ControllerName       = "certificate-policy-controller"
 )
 
@@ -119,22 +118,6 @@ func (r *CertificatePolicyReconciler) Reconcile(ctx context.Context, request ctr
 	}
 
 	if instance.ObjectMeta.DeletionTimestamp.IsZero() {
-		updateNeeded := false
-
-		if ensureDefaultLabel(instance) {
-			reqLogger.V(1).Info("Label update needed")
-
-			updateNeeded = true
-		}
-
-		if updateNeeded {
-			if err := r.Update(ctx, instance); err != nil {
-				reqLogger.Info("Requeuing due to error updating the label", "Error", err)
-
-				return reconcile.Result{Requeue: true}, nil
-			}
-		}
-
 		instance.Status.CompliancyDetails = make(map[string]policyv1.CompliancyDetails)
 
 		r.handleAddingPolicy(ctx, instance)
@@ -146,32 +129,6 @@ func (r *CertificatePolicyReconciler) Reconcile(ctx context.Context, request ctr
 	return reconcile.Result{}, nil
 }
 
-func ensureDefaultLabel(instance *policyv1.CertificatePolicy) bool {
-	log.V(3).Info("Entered ensureDefaultLabel")
-	// we need to ensure this label exists -> category: "System and Information Integrity"
-	if instance.ObjectMeta.Labels == nil {
-		newlbl := make(map[string]string)
-		newlbl["category"] = grcCategory
-		instance.ObjectMeta.Labels = newlbl
-
-		return true
-	}
-
-	if _, ok := instance.ObjectMeta.Labels["category"]; !ok {
-		instance.ObjectMeta.Labels["category"] = grcCategory
-
-		return true
-	}
-
-	if instance.ObjectMeta.Labels["category"] != grcCategory {
-		instance.ObjectMeta.Labels["category"] = grcCategory
-
-		return true
-	}
-
-	return false
-}
-
 // PeriodicallyExecCertificatePolicies always check status - let this be the only function in the controller.
 func (r *CertificatePolicyReconciler) PeriodicallyExecCertificatePolicies(
 	ctx context.Context, freq uint, loopflag bool,
diff --git a/controllers/certificatepolicy_controller_test.go b/controllers/certificatepolicy_controller_test.go
index 7a6696b1..b4e12506 100644
--- a/controllers/certificatepolicy_controller_test.go
+++ b/controllers/certificatepolicy_controller_test.go
@@ -205,35 +205,6 @@ func TestCheckComplianceBasedOnDetails(_ *testing.T) {
 	checkComplianceBasedOnDetails(&certPolicy)
 }
 
-func TestEnsureDefaultLabel(t *testing.T) {
-	certPolicy := &policiesv1.CertificatePolicy{
-		ObjectMeta: metav1.ObjectMeta{
-			Name:      "foo",
-			Namespace: "default",
-		},
-	}
-	updateNeeded := ensureDefaultLabel(certPolicy)
-	assert.True(t, updateNeeded)
-
-	labels1 := map[string]string{}
-	labels1["category"] = grcCategory
-	certPolicy.Labels = labels1
-	updateNeeded = ensureDefaultLabel(certPolicy)
-	assert.False(t, updateNeeded)
-
-	labels2 := map[string]string{}
-	labels2["category"] = "foo"
-	certPolicy.Labels = labels2
-	updateNeeded = ensureDefaultLabel(certPolicy)
-	assert.True(t, updateNeeded)
-
-	labels3 := map[string]string{}
-	labels3["foo"] = grcCategory
-	certPolicy.Labels = labels3
-	updateNeeded = ensureDefaultLabel(certPolicy)
-	assert.True(t, updateNeeded)
-}
-
 func TestCheckComplianceChangeBasedOnDetails(t *testing.T) {
 	certPolicy := policiesv1.CertificatePolicy{
 		ObjectMeta: metav1.ObjectMeta{