Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://issues.redhat.com/browse/ACM-16145--pm request for disconnect… (delayed) #7480

Open
wants to merge 2 commits into
base: 2.12_stage
Choose a base branch
from

Conversation

swopebe
Copy link
Contributor

@swopebe swopebe commented Feb 6, 2025

… info

Copy link

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swopebe

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…t disconnected--PM request, clean up of file and section.

The following example shows a `ManagedClusterImageRegistry` custom resource definition:
+
Copy link
Contributor Author

@swopebe swopebe Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content added here that we can go over.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full steps and details for adding a ManagedClusterIMageRegistry are here: https://docs.redhat.com/en/documentation/red_hat_advanced_cluster_management_for_kubernetes/2.12/html/clusters/cluster_mce_overview#specify-registry-img-on-managed-clusters-for-import ... so can we just advise them to review that directly?

Copy link
Contributor Author

@swopebe swopebe Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the template, I look at step 4 and that's how I know what needs to be added:

https://issues.redhat.com/browse/ACM-16145

Are we saying we don't need the content that I added--just the link? Since we are pretty swamped right now, I need to table this to work on some other items and will wait for response.

@@ -8,4 +8,4 @@ Continue reading to learn more about release images:
* xref:../cluster_lifecycle/release_images_specify.adoc#release-images-specify[Specifying release images]
* xref:../cluster_lifecycle/release_image_connected.adoc#release-images-connected[Maintaining a custom list of release images while connected]
* xref:../cluster_lifecycle/release_image_disconn.adoc#release-images-disconnected[Maintaining a custom list of release images while disconnected]
* xref:../cluster_lifecycle/sync_release_image.adoc#synchronizing-available-release-images[Synchronizing available release images]
* xref:../cluster_lifecycle/release_image_sync.adoc#synchronizing-available-release-images[Synchronizing available release images]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the name and all links to reflect how the rest of the files are named so I don't have to keep hunting for it!

@swopebe swopebe requested a review from augustrh February 7, 2025 21:35
@swopebe swopebe changed the title https://issues.redhat.com/browse/ACM-16145--pm request for disconnect… https://issues.redhat.com/browse/ACM-16145--pm request for disconnect… (delayed) Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants