ACM-18042: Adopt policy best practices (GRC) #7524
Conversation
dhaiducek
changed the title
| @@ -182,6 +182,11 @@ spec: | |||
| labelSelector: | |||
| matchLabels: | |||
| cloud: "IBM" | |||
There was a problem hiding this comment.
formatting seems to be off here.
| + | ||
| ---- | ||
| oc delete policies.policy.open-cluster-management.io <policy-name> -n <policy-namespace> | ||
| ---- | ||
| + | ||
| After your policy is deleted, it is removed from your target cluster or clusters. Verify that your policy is removed by running the following command: `oc get policies.policy.open-cluster-management.io <policy-name> -n <policy-namespace>` | ||
|
|
There was a problem hiding this comment.
This had a random (+) in the file, which was overused bc it was built with bullets and steps were merged together. Quick format fix.
|
@swopebe If needed, I can handle the rebase/conflicts once the review edits are complete. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dhaiducek, jc-berger, swopebe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Use fully qualified name for policy - Remove `ManagedClusterConditionAvailable` When dealing with policies, this setting is not recommended since it could introduce churn. - Add `tolerations` to `Placement` Not having these tolerations could introduce churn if the managed cluster becomes unavailable. Signed-off-by: Dale Haiducek <[email protected]>
dhaiducek
force-pushed
the
update-policy-placement
branch
from
8b849af to
036985c
Compare
|
New changes are detected. LGTM label has been removed. |
|
@swopebe I rebased it and think I got it back to where it was previously, but when you have a minute please double check the edits made here to make sure. |
ManagedClusterConditionAvailabletolerationstoPlacementref: https://issues.redhat.com/browse/ACM-18042
Split from:
ConfigurationPolicycustomMessagedoc (GRC) #7521