Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Hard-coded hrefs in templates are broken in hashbang mode #175

Open
robertjd opened this issue Sep 20, 2016 · 0 comments
Open

Hard-coded hrefs in templates are broken in hashbang mode #175

robertjd opened this issue Sep 20, 2016 · 0 comments
Labels
needs review
Milestone
1.0.1

Comments

@robertjd
Copy link
Member

In the login form we have a hard-coded link to /forgot, for the forgot password view. This link is broken if you're using hashbang-based routing. These hrefs should dynamically respond to $location html5 mode enabled.
@robertjd robertjd added the open label Sep 20, 2016
@mraible mraible self-assigned this Oct 19, 2016
@mraible mraible added this to the 1.0.1 milestone Oct 19, 2016
mraible added a commit that referenced this issue Oct 19, 2016
@mraible
Make links to other pages relative
a3e2ef1 
Fixes #175.
mraible added a commit that referenced this issue Oct 24, 2016
@mraible
Use $location.path() to navigate between pages, allowing both HTML5 a…
42e46b4 
…nd hashbang modes to work

Fixes #175.
@mraible mraible mentioned this issue Oct 24, 2016
Open
@omgitstom omgitstom removed the open label Oct 24, 2016
@mraible mraible mentioned this issue Oct 25, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
3 participants
@mraible @robertjd @omgitstom