Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ctrl-c future handling in mining proxy #1409

Open
jbesraa opened this issue Jan 28, 2025 · 0 comments
Open

Fix ctrl-c future handling in mining proxy #1409

jbesraa opened this issue Jan 28, 2025 · 0 comments
Labels
refactor Implies refactoring code roles Pertains to all roles

Comments

@jbesraa
Copy link
Contributor

jbesraa commented Jan 28, 2025

in https://github.com/stratum-mining/stratum/blob/main/roles/mining-proxy/src/lib/mod.rs#L173 tokio::join is used which is not correct because the role should stop as soon as one of the futures resolves and not both of them.
@plebhash plebhash added refactor Implies refactoring code roles Pertains to all roles labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Implies refactoring code roles Pertains to all roles
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbesraa @plebhash