-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need to deprecate binary_codec_sv2
and restructure binary_sv2
+ derive_codec_sv2
#1462
Comments
one detail coming from #1459 that we should clean up here is some leftover lifetime parameters that were originally motivated by reference: 3f80718#r1947844273 |
plebhash
changed the title
Restructure the binary_sv2 crate.
need to deprecate Feb 10, 2025
binary_codec_sv2
and restructure binary_sv2
+ derive_codec_sv2
Reimplement or redesign parts of |
this will introduce breaking changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current structure of
binary_sv2
does not follow best practices. Typically, a crate defining aproc_macro
only includes an additional crate for the macro’s implementation. However, inbinary_sv2
, we have two separate crates—one for theproc_macro
implementation and another for the primitives required for macro scaffolding. Due to the tightly coupled nature of theproc_macro
implementation with the module structure, restructuring it requires rewriting some parts of the macro to align with the proposed design.Kudos to @plebhash for pointing this out and suggesting a better structure: #1459 (comment)
The text was updated successfully, but these errors were encountered: