Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: 'isfolder' undefined #12

Open
florisvb opened this issue May 21, 2024 · 3 comments
Open

error: 'isfolder' undefined #12

florisvb opened this issue May 21, 2024 · 3 comments

Comments

@florisvb
Copy link

I am getting this error when running octave gocal.m with my own data, as well as all three of the test datasets. Any idea what is happening?

caveman@RiffellCave1:~/big_tunnel_calibration_test/latest/MultiCamSelfCal/MultiCamSelfCal$ octave gocal.m --config=/home/caveman/big_tunnel_calibration_test/latest/MultiCamSelfCal/strawlab/test-data/caldata20130726_122220
warning: function ../CalTechCal/quiver.m shadows a core library function
warning: called from
gocal.m at line 23 column 1
arg = --config=/home/caveman/big_tunnel_calibration_test/latest/MultiCamSelfCal/strawlab/test-data/caldata20130726_122220
error: 'isfolder' undefined near line 14 column 4
error: called from
read_generic_configuration at line 14 column 1
read_configuration at line 43 column 8
gocal.m at line 26 column 8

I do not get this error on an older commit: 94e0bb2

@slivingston
Copy link

Which version of octave do you have? The function isfolder was added relatively recently (gnu-octave/octave@7bbad5a).

@florisvb
Copy link
Author

florisvb commented May 22, 2024 via email

@astraw
Copy link
Member

astraw commented May 22, 2024

The specific lines with isfolder were introduced here 9a089aff to fix a deprecation warning. The change should be trivial for you to revert, however. Hopefully there won't be other incompatibilities.

If you have a dataset where the calibration works with Ubuntu 18 and not on Ubuntu 20, that would be valuable to add here as a test to ensure we don't have regressions in the future. (Fixing deprecation warnings as time marches forward I do not consider a regression.)

I would appreciate it if you keep this issue updated with your findings, as I would certainly like to avoid regressions in convergence or other computational aspects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants