Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[weather-api-widget] 3-day forecast use night variants icons during the day #459

Open
xfzv opened this issue Oct 30, 2024 · 1 comment
Open

[weather-api-widget] 3-day forecast use night variants icons during the day #459

xfzv opened this issue Oct 30, 2024 · 1 comment

Comments

@xfzv
Copy link

xfzv commented Oct 30, 2024

Original conversation

Opening this issue as requested in Ryuno-Ki@449f2db#commitcomment-148523178

With

icons = "weather-underground-icons",
icons_extension = ".png",
show_daily_forecast = true,

The night variant icons are used for the 3-day forecast during day time (and probably the other way around, unconfirmed for now):

1

Reverting Ryuno-Ki@449f2db solves the issue but then the current condition icon (in the bar and in the preview) is using the wrong variant:

2
xfzv referenced this issue in Ryuno-Ki/awesome-wm-widgets Oct 30, 2024
@Ryuno-Ki
fix: inverse logic
449f2db 
I only need to add a prefix when it is not day.

Signed-off-by: André Jaenisch <[email protected]>
@Ryuno-Ki
Copy link
Contributor

Will look into it once #458 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ryuno-Ki @xfzv