From d67b17f91e26a0a5182758d6032b5cb05c6666cd Mon Sep 17 00:00:00 2001 From: Paolo Patierno Date: Wed, 1 Jun 2022 16:15:33 +0200 Subject: [PATCH] Fixed consumer fetch max wait time due to Sarama potential bug (#183) Signed-off-by: Paolo Patierno --- cmd/main.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cmd/main.go b/cmd/main.go index 0fb6a09..ca96c2d 100644 --- a/cmd/main.go +++ b/cmd/main.go @@ -36,6 +36,7 @@ var ( ) var saramaLogger = log.New(io.Discard, "[Sarama] ", log.LstdFlags) + func main() { // get canary configuration canaryConfig := config.NewCanaryConfig() @@ -98,7 +99,9 @@ func newClient(canaryConfig *config.CanaryConfig) (sarama.Client, error) { config.Producer.RequiredAcks = sarama.WaitForAll config.Producer.Retry.Max = 0 config.Consumer.Return.Errors = true - + // this Sarama fix https://github.com/Shopify/sarama/pull/2227 increases the canary e2e latency + // it shows a potential bug in Sarama. We revert the value back here while waiting for a Sarama fix + config.Consumer.MaxWaitTime = 250 * time.Millisecond if canaryConfig.TLSEnabled { config.Net.TLS.Enable = true