Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jayway:json-path dependency is required but excluded from kafka-oauth-client #209

Open
ozangunalp opened this issue Oct 24, 2023 · 2 comments

Comments

@ozangunalp
Copy link

Since the change 47e76b1 the json-path dependency is required by the PricincipalExtractor but still is excluded from the kafka-oauth-client : https://github.com/strimzi/strimzi-kafka-oauth/blob/9fb18887f659817ea216a669a700440525fab866/oauth-client/pom.xml#L18C19-L18C19

This causes at least quarkusio/quarkus#36653 for native builds but I think would result in class not founds at JVM runtime if json-path is not added manually to the classpath.

@mstruk
Copy link
Contributor

mstruk commented Oct 24, 2023

Looks like a bug indeed. You can work around by explicitly adding json-path dependency to your project, but I agree it should not be excluded any more from the client. Looks like we need a test in the testsuite for this.

@ozangunalp
Copy link
Author

Thanks!

The issue here is the change to the PricincipalExtractor effectively pulls json-path and transitively json-smart, whereas before only json related library required by the kafka-oauth-client was jackson-databind.

I just want to make sure this is done willingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants