Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamma distribution? #21

Open
andywong36 opened this issue Jan 16, 2023 · 2 comments
Open

Gamma distribution? #21

andywong36 opened this issue Jan 16, 2023 · 2 comments
Assignees

Comments

@andywong36
Copy link
Contributor

andywong36 commented Jan 16, 2023

Is there a plan to add support for a gamma distribution GLM in the future?

The current list of supported GLM distributions are:

['bernoulli', 'binomial', 'categorical', 'multinomial', 'poisson', 'negative_binomial', 'exponential', 'weibull', 'gaussian', 'ceiling_weibull']

There are also a large number of transforms defined in foundry/glm/glm.py:66-120. Have these been validated? Can we assume that we're actually doing MLE of the parameters in the GLM (assuming penalty=0.), or are we optimizing for some other objective?

@jwdink
Copy link
Contributor

jwdink commented Jan 17, 2023

Most of the distributions in torch.distributions are supported by just creating your own "Family" instance. Adding support for other aliases (eg being able to pass a string "gamma" to Glm) is also super easy -- feel free to create a branch/PR for this.

I'm not sure I understand your second question, but yes I believe the optimized params should be the MLEs if penalty=0

@jwdink
Copy link
Contributor

jwdink commented Jan 30, 2023

I thought about this in a059f63 but there's actually two complications:

@jwdink jwdink reopened this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants