Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - Redis support #11

Open
iMicknl opened this issue Feb 29, 2016 · 9 comments
Open

Feature request - Redis support #11

iMicknl opened this issue Feb 29, 2016 · 9 comments

Comments

@iMicknl
Copy link

iMicknl commented Feb 29, 2016

I would like to have Redis support, because there is no decent page cache plugin at the moment that also supports Redis.

Would be nice to have support for:

If you have a good idea how to merge this in easily, it would be very nice. Otherwise I will have a look the in next month, if I can add Redis support and open a PR.

@fgilio
Copy link

fgilio commented Mar 2, 2016

This would be awesome

@stayallive
Copy link

<3 +1!

@JJJ
Copy link
Contributor

JJJ commented Mar 30, 2016

This would be very awesome. Anyone had a chance to try this out? PR's encouraged!

@renatonascalves
Copy link

+1 I can't help with a PR, but with testing.

@szepeviktor
Copy link

szepeviktor commented Feb 15, 2017

Could we enable wp-redis support in wp-spider-cache?

It is a high quality plugin.

@szepeviktor
Copy link

@JJJ I'd like to implement Redis support by wp-redis.

Could you start me up where to modify the existing code to switch engine?

@danielbachhuber
Copy link

Why does WP Spider Cache need Redis support when WP Redis already has Redis support (and comprehensive test coverage to boot)?

@szepeviktor
Copy link

szepeviktor commented Feb 21, 2017

I've tried wp-redis + wp-spider-cache/advanced-cache.php based on #21 (comment)

PHP Fatal error:  Uncaught Error: Class 'Memcache' not found in */wp-content/plugins/wp-spider-cache/wp-spider-cache/includes/base-object.php:246

@JJJ
Copy link
Contributor

JJJ commented Feb 21, 2017

@szepeviktor I think what you're starting to do is a great approach:

  • Install both WP Spider Cache & WP Redis
  • Make changes to WP Spider Cache to work alongside WP Redis
  • Send PR's for any general improvements
  • Send PR's for WP Redis specific improvements

Long term, I can imagine bundling our own shim to work with whatever WP Redis provides, and/or relying on it entirely and adapting it's approach for our own internals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants