Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline CSS #130

Open
NicholasLYang opened this issue Feb 23, 2018 · 1 comment
Open

Inline CSS #130

NicholasLYang opened this issue Feb 23, 2018 · 1 comment
Labels
big project Try your best! So long as you work on this you're good enhancement New feature

Comments

@NicholasLYang
Copy link
Contributor

Overall our css is pretty good, but we have a few bits that can be sped up. First, bootstrap needs to be inlined into our regular CSS. Right now it's a separate file (bootstrap.min.css), which needs to be loaded. That's why there's a flash of unstyled content at the beginning. There's two options here: the optimal one is to literally inline it into the index.html. This requires a little bit of setup in gulp, but it'd be the fastest. The second is to add it to main-index.css. This is less work, but it doesn't completely fix the loading times

@AndySok AndySok added the enhancement New feature label Mar 2, 2021
@AndySok AndySok added small project 2 of these and youre good for the year big project Try your best! So long as you work on this you're good and removed small project 2 of these and youre good for the year labels Apr 15, 2021
@AndySok
Copy link
Contributor

AndySok commented Apr 15, 2021

For the devs: part of the re-styling project, instructions were outlined by Nicholas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big project Try your best! So long as you work on this you're good enhancement New feature
Projects
None yet
Development

No branches or pull requests

2 participants