Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User profile and settings #16

Open
kgilles opened this issue Dec 20, 2023 · 2 comments · Fixed by #178, #158 or #190
Open

User profile and settings #16

kgilles opened this issue Dec 20, 2023 · 2 comments · Fixed by #178, #158 or #190
Assignees
Labels
enhancement New feature or request

Comments

@kgilles
Copy link
Member

kgilles commented Dec 20, 2023

After user auth flow(issue #13) has been added to the UI we can expand on the user features and create the user profile and settings pages.

@kgilles kgilles converted this from a draft issue Dec 20, 2023
@kgilles kgilles changed the title User settings User profile and settings Dec 20, 2023
@kgilles kgilles moved this from 🔖 Ready to 📋 Backlog in Sublinks Frontend Jan 23, 2024
@kgilles kgilles added the enhancement New feature or request label Jan 23, 2024
@slickplaid
Copy link
Contributor

See #79 (review) for some issues (item 1, 2, and 3 in that list) that should be addressed in this feature that were left out of the initial #13 feature completion.

The initial load of user settings should ideally not rely on a client side call to /api/v3/site to retrieve user preferences and make page updates after the page has finished loading. Ideally this should be server-side rendered, or if we want to defer full SSR until things are more complete, support skeleton loading indicators on the content and rely on the client to initially fetch the content (initial load of the page would be without data, then hydrated).

Either way, re-hydration based on user settings or changes to the user settings should be supported, so it might make sense to progressively improve rather than jumping to full SSR unless warranted.

If needed we could split this out into two or more issues (create and define user settings and page, allow page to be dynamic when adjusting user preferences, support SSR for logged in user's user preferences) to be addressed individually if this proves to be too much for a single issue.

@kgilles kgilles moved this from 📋 Backlog to 🔖 Ready in Sublinks Frontend Mar 14, 2024
@kgilles kgilles self-assigned this May 16, 2024
@kgilles kgilles moved this from 🔖 Ready to 🏗 In progress in Sublinks Frontend May 16, 2024
@kgilles kgilles linked a pull request Jun 19, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Sublinks Frontend Jun 20, 2024
@kgilles kgilles moved this from ✅ Done to 🏗 In progress in Sublinks Frontend Jun 20, 2024
@kgilles kgilles linked a pull request Jun 20, 2024 that will close this issue
@kgilles kgilles removed the status in Sublinks Frontend Jun 20, 2024
@kgilles kgilles moved this to 🏗 In progress in Sublinks Frontend Jun 20, 2024
@kgilles kgilles reopened this Jun 20, 2024
@kgilles kgilles linked a pull request Jul 9, 2024 that will close this issue
@kgilles
Copy link
Member Author

kgilles commented Jul 15, 2024

Depends on sublinks/sublinks-api#398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
2 participants