Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$600 in SQT] Helm Charts for SubQuery Network Services #422

Open
jamesbayly opened this issue Jun 7, 2024 · 22 comments
Open

[$600 in SQT] Helm Charts for SubQuery Network Services #422

jamesbayly opened this issue Jun 7, 2024 · 22 comments
Assignees

Comments

@jamesbayly
Copy link
Contributor

Context:

Currently we only document how to run our Node Operator Services (https://raw.githubusercontent.com/subquery/network-indexer-services) on single node vm or using Docker, while some node operators wanted to run it on kubernetes.

We should be able to provide a limited featured version and make it work with kubernetes. This limited feature edition will only support Node Operators with RPC projects.

Requirements:

  • Fix compatibility issues
    • find another way to show coordinator’s std output or disable it
    • disable the feature to create managed subql projects
  • Create a helmchart to help people deploy the whole stack
    • indexer proxy
    • coordinator
    • ipfs
    • ingress
@jamesbayly jamesbayly changed the title Helm Charts for SubQuery Network Services [$600 in SQT] Helm Charts for SubQuery Network Services Jun 10, 2024
@Faizalhidayat
Copy link

I have created a Helm chart that .

try this https://github.com/Faizalhidayat/subquery-helm-chart.git

@icezohu
Copy link
Collaborator

icezohu commented Jul 3, 2024

Hi @Faizalhidayat ,
Thank you for your efforts in resolving this issue. We will schedule a detailed review of the Helm charts soon. As for the task, it should also fix the compatibility issues mentioned above. Will you contribute to these?

@Faizalhidayat
Copy link

Thank you for your appreciation and for considering me for this task. I’m glad to hear that a detailed review of the Helm charts is being scheduled.

@jamesbayly
Copy link
Contributor Author

@Faizalhidayat you are on the right track, but we need you to complete the listed compatibility issues before we can start reviewing.

Without fixing these issues, these helm charts will not work correctly

@Faizalhidayat
Copy link

Faizalhidayat commented Jul 19, 2024

detail what problem I haven't solved yet?? This task only focus create to helm chart subquery ???

@jamesbayly
Copy link
Contributor Author

detail what problem I haven't solved yet?? This task only focus create to helm chart subquery ???

Fix compatibility issues

  • find another way to show coordinator’s std output or disable it
  • disable the feature to create managed subql projects

@Faizalhidayat
Copy link

i already update my helm chart following issue above

@icezohu
Copy link
Collaborator

icezohu commented Jul 19, 2024

Hi, @Faizalhidayat

  • find another way to show coordinator’s std output or disable it
    we show coordinator and index node std output through docker sock, which is displaying on the admin UI. I think k8s does not allow to expose its admin interface to a coodinator pod. I think the simple way is to hide them in admin UI.

  • disable the feature to create managed subql projects
    creating a subql project will throw error in k8s pod, as you may know, we used to create container through docker sock. The simple way is to reject create subql projects when input subql cid into the admin UI field.

@Faizalhidayat
Copy link

Faizalhidayat commented Jul 19, 2024

i already update the helm chart if any error please reply

@Faizalhidayat
Copy link

Faizalhidayat commented Jul 22, 2024

Any update ?? @icezohu ? @jamesbayly ?

@Faizalhidayat
Copy link

@icezohu please?

@icezohu
Copy link
Collaborator

icezohu commented Jul 25, 2024

@Faizalhidayat Sorry for the delay. I need to ask you again, that do you want to contribute to code change of the coordinator app network-indexer-services/apps/indexer-coordinator, to support compatibility of kubernetes deploy?

@icezohu
Copy link
Collaborator

icezohu commented Jul 25, 2024

Sorry, according to my prev suggestion, the code should be more related to the frontend app code at network-indexer-services/apps/indexer-admin

@Faizalhidayat
Copy link

So i must focus on frontend right ??

@icezohu
Copy link
Collaborator

icezohu commented Jul 25, 2024

Yes, or may be including backend part as well. That may require more of the project background knowledge. Try if you can. Tell us if it's difficult for you to implement.

@Faizalhidayat
Copy link

lets point this task .

  1. Fix compatibility issues
    find another way to show coordinator’s std output or disable it
    disable the feature to create managed subql projects on network-indexer-services/apps/indexer-admin , right?

2.Create a helmchart to help people deploy the whole stack
indexer proxy
coordinator
ipfs
ingress

its different task , right ?

@Faizalhidayat
Copy link

@icezohu can you answer my question above

@icezohu
Copy link
Collaborator

icezohu commented Jul 31, 2024

@Faizalhidayat Yes, they are different. We just release a new version of coordinator yesterday, which supports adding self hosted subquery projects. I think it's better to provide a startup parameter in coordinator/typescript just to disable adding coordinator hosted subquery projects and disable coordinator logs.
Btw, is your helm charts tested well? I can't start it up straightforwardly or after some tweaking. And also the startup command you provided in readme is not correct, though this does not really matter.

@Faizalhidayat
Copy link

last question

1.find another way to show coordinator’s std output or disable it
disable the feature to create managed subql projects
on https://github.com/subquery/network-indexer-services , right?

  1. create helm chart Create a helmchart to help people deploy the whole stack for kubernetes ?
    indexer proxy
    coordinator
    ipfs
    ingress

Faizalhidayat added a commit to Faizalhidayat/network-indexer-services that referenced this issue Sep 16, 2024
@Faizalhidayat
Copy link

Faizalhidayat commented Sep 16, 2024

hi @icezohu @jamesbayly can you check my pr
#504

@Faizalhidayat
Copy link

@icezohu

@pamanseau
Copy link

I will do the Helm chart but I have compatibility issues #527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

No branches or pull requests

4 participants