From 2a2ecab0d530807455143348cd18df6421b2304a Mon Sep 17 00:00:00 2001 From: Francisco Sousa Date: Fri, 2 Sep 2022 12:56:28 +0100 Subject: [PATCH] Implement breaking svelte-kit changes (#50) Implement the breaking changes necessary to upgrade svelte-kit. Main focus is the new routes structure. Check https://kit.svelte.dev/docs/introduction for info. Also, `svelte-kit` now requires `vite` as a separate dependency. This fixes that. Moved the API_URL building logic to `vite.config.ts` also. I also noticed that the LICENSE file was not matching to the license in `frontend`. AFAIK we should be using MPL license, which saves us from people copying the design but still gives us zero responsibility in terms of warranty and zero liability. --- .tool-versions | 2 +- LICENSE.md | 357 +++++- frontend/.gitignore | 1 + frontend/.node-version | 2 +- frontend/.npmrc | 1 - frontend/netlify.toml | 3 +- frontend/package.json | 37 +- frontend/postcss.config.cjs | 3 - frontend/src/app.html | 7 +- frontend/src/lib/api.ts | 27 +- .../{__layout.svelte => +layout.svelte} | 16 +- frontend/src/routes/+layout.ts | 8 + .../src/routes/{index.svelte => +page.svelte} | 6 +- .../{[room].svelte => [room]/+page.svelte} | 18 +- frontend/src/routes/[room]/+page.ts | 6 + .../{error.svelte => error/+page.svelte} | 0 frontend/svelte.config.js | 19 - frontend/tailwind.config.cjs | 3 +- frontend/tsconfig.json | 29 +- frontend/vite.config.ts | 26 + frontend/yarn.lock | 1091 ++++++++++------- 21 files changed, 1087 insertions(+), 575 deletions(-) rename frontend/src/routes/{__layout.svelte => +layout.svelte} (88%) create mode 100644 frontend/src/routes/+layout.ts rename frontend/src/routes/{index.svelte => +page.svelte} (97%) rename frontend/src/routes/{[room].svelte => [room]/+page.svelte} (83%) create mode 100644 frontend/src/routes/[room]/+page.ts rename frontend/src/routes/{error.svelte => error/+page.svelte} (100%) create mode 100644 frontend/vite.config.ts diff --git a/.tool-versions b/.tool-versions index 0c5fd0d..43e4098 100644 --- a/.tool-versions +++ b/.tool-versions @@ -1,4 +1,4 @@ -nodejs 16.14.0 +nodejs 16.17.0 elixir 1.13.3 erlang 24.3.4 ruby 2.6.6 diff --git a/LICENSE.md b/LICENSE.md index 9ee393d..0afe08d 100644 --- a/LICENSE.md +++ b/LICENSE.md @@ -1,7 +1,356 @@ -ISC License +Mozilla Public License Version 2.0 +================================== -Copyright 2020 Finiam +### 1. Definitions -Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted, provided that the above copyright notice and this permission notice appear in all copies. +**1.1. “Contributor”** + means each individual or legal entity that creates, contributes to + the creation of, or owns Covered Software. + +**1.2. “Contributor Version”** + means the combination of the Contributions of others (if any) used + by a Contributor and that particular Contributor's Contribution. + +**1.3. “Contribution”** + means Covered Software of a particular Contributor. + +**1.4. “Covered Software”** + means Source Code Form to which the initial Contributor has attached + the notice in Exhibit A, the Executable Form of such Source Code + Form, and Modifications of such Source Code Form, in each case + including portions thereof. + +**1.5. “Incompatible With Secondary Licenses”** + means + +* **(a)** that the initial Contributor has attached the notice described + in Exhibit B to the Covered Software; or +* **(b)** that the Covered Software was made available under the terms of + version 1.1 or earlier of the License, but not also under the + terms of a Secondary License. + +**1.6. “Executable Form”** + means any form of the work other than Source Code Form. + +**1.7. “Larger Work”** + means a work that combines Covered Software with other material, in + a separate file or files, that is not Covered Software. + +**1.8. “License”** + means this document. + +**1.9. “Licensable”** + means having the right to grant, to the maximum extent possible, + whether at the time of the initial grant or subsequently, any and + all of the rights conveyed by this License. + +**1.10. “Modifications”** + means any of the following: + +* **(a)** any file in Source Code Form that results from an addition to, + deletion from, or modification of the contents of Covered + Software; or +* **(b)** any new file in Source Code Form that contains any Covered + Software. + +**1.11. “Patent Claims” of a Contributor** + means any patent claim(s), including without limitation, method, + process, and apparatus claims, in any patent Licensable by such + Contributor that would be infringed, but for the grant of the + License, by the making, using, selling, offering for sale, having + made, import, or transfer of either its Contributions or its + Contributor Version. + +**1.12. “Secondary License”** + means either the GNU General Public License, Version 2.0, the GNU + Lesser General Public License, Version 2.1, the GNU Affero General + Public License, Version 3.0, or any later versions of those + licenses. + +**1.13. “Source Code Form”** + means the form of the work preferred for making modifications. + +**1.14. “You” (or “Your”)** + means an individual or a legal entity exercising rights under this + License. For legal entities, “You” includes any entity that + controls, is controlled by, or is under common control with You. For + purposes of this definition, “control” means **(a)** the power, direct + or indirect, to cause the direction or management of such entity, + whether by contract or otherwise, or **(b)** ownership of more than + fifty percent (50%) of the outstanding shares or beneficial + ownership of such entity. + + +### 2. License Grants and Conditions + +#### 2.1. Grants + +Each Contributor hereby grants You a world-wide, royalty-free, +non-exclusive license: + +* **(a)** under intellectual property rights (other than patent or trademark) + Licensable by such Contributor to use, reproduce, make available, + modify, display, perform, distribute, and otherwise exploit its + Contributions, either on an unmodified basis, with Modifications, or + as part of a Larger Work; and +* **(b)** under Patent Claims of such Contributor to make, use, sell, offer + for sale, have made, import, and otherwise transfer either its + Contributions or its Contributor Version. + +#### 2.2. Effective Date + +The licenses granted in Section 2.1 with respect to any Contribution +become effective for each Contribution on the date the Contributor first +distributes such Contribution. + +#### 2.3. Limitations on Grant Scope + +The licenses granted in this Section 2 are the only rights granted under +this License. No additional rights or licenses will be implied from the +distribution or licensing of Covered Software under this License. +Notwithstanding Section 2.1(b) above, no patent license is granted by a +Contributor: + +* **(a)** for any code that a Contributor has removed from Covered Software; + or +* **(b)** for infringements caused by: **(i)** Your and any other third party's + modifications of Covered Software, or **(ii)** the combination of its + Contributions with other software (except as part of its Contributor + Version); or +* **(c)** under Patent Claims infringed by Covered Software in the absence of + its Contributions. + +This License does not grant any rights in the trademarks, service marks, +or logos of any Contributor (except as may be necessary to comply with +the notice requirements in Section 3.4). + +#### 2.4. Subsequent Licenses + +No Contributor makes additional grants as a result of Your choice to +distribute the Covered Software under a subsequent version of this +License (see Section 10.2) or under the terms of a Secondary License (if +permitted under the terms of Section 3.3). + +#### 2.5. Representation + +Each Contributor represents that the Contributor believes its +Contributions are its original creation(s) or it has sufficient rights +to grant the rights to its Contributions conveyed by this License. + +#### 2.6. Fair Use + +This License is not intended to limit any rights You have under +applicable copyright doctrines of fair use, fair dealing, or other +equivalents. + +#### 2.7. Conditions + +Sections 3.1, 3.2, 3.3, and 3.4 are conditions of the licenses granted +in Section 2.1. + + +### 3. Responsibilities + +#### 3.1. Distribution of Source Form + +All distribution of Covered Software in Source Code Form, including any +Modifications that You create or to which You contribute, must be under +the terms of this License. You must inform recipients that the Source +Code Form of the Covered Software is governed by the terms of this +License, and how they can obtain a copy of this License. You may not +attempt to alter or restrict the recipients' rights in the Source Code +Form. + +#### 3.2. Distribution of Executable Form + +If You distribute Covered Software in Executable Form then: + +* **(a)** such Covered Software must also be made available in Source Code + Form, as described in Section 3.1, and You must inform recipients of + the Executable Form how they can obtain a copy of such Source Code + Form by reasonable means in a timely manner, at a charge no more + than the cost of distribution to the recipient; and + +* **(b)** You may distribute such Executable Form under the terms of this + License, or sublicense it under different terms, provided that the + license for the Executable Form does not attempt to limit or alter + the recipients' rights in the Source Code Form under this License. + +#### 3.3. Distribution of a Larger Work + +You may create and distribute a Larger Work under terms of Your choice, +provided that You also comply with the requirements of this License for +the Covered Software. If the Larger Work is a combination of Covered +Software with a work governed by one or more Secondary Licenses, and the +Covered Software is not Incompatible With Secondary Licenses, this +License permits You to additionally distribute such Covered Software +under the terms of such Secondary License(s), so that the recipient of +the Larger Work may, at their option, further distribute the Covered +Software under the terms of either this License or such Secondary +License(s). + +#### 3.4. Notices + +You may not remove or alter the substance of any license notices +(including copyright notices, patent notices, disclaimers of warranty, +or limitations of liability) contained within the Source Code Form of +the Covered Software, except that You may alter any license notices to +the extent required to remedy known factual inaccuracies. + +#### 3.5. Application of Additional Terms + +You may choose to offer, and to charge a fee for, warranty, support, +indemnity or liability obligations to one or more recipients of Covered +Software. However, You may do so only on Your own behalf, and not on +behalf of any Contributor. You must make it absolutely clear that any +such warranty, support, indemnity, or liability obligation is offered by +You alone, and You hereby agree to indemnify every Contributor for any +liability incurred by such Contributor as a result of warranty, support, +indemnity or liability terms You offer. You may include additional +disclaimers of warranty and limitations of liability specific to any +jurisdiction. + + +### 4. Inability to Comply Due to Statute or Regulation + +If it is impossible for You to comply with any of the terms of this +License with respect to some or all of the Covered Software due to +statute, judicial order, or regulation then You must: **(a)** comply with +the terms of this License to the maximum extent possible; and **(b)** +describe the limitations and the code they affect. Such description must +be placed in a text file included with all distributions of the Covered +Software under this License. Except to the extent prohibited by statute +or regulation, such description must be sufficiently detailed for a +recipient of ordinary skill to be able to understand it. + + +### 5. Termination + +**5.1.** The rights granted under this License will terminate automatically +if You fail to comply with any of its terms. However, if You become +compliant, then the rights granted under this License from a particular +Contributor are reinstated **(a)** provisionally, unless and until such +Contributor explicitly and finally terminates Your grants, and **(b)** on an +ongoing basis, if such Contributor fails to notify You of the +non-compliance by some reasonable means prior to 60 days after You have +come back into compliance. Moreover, Your grants from a particular +Contributor are reinstated on an ongoing basis if such Contributor +notifies You of the non-compliance by some reasonable means, this is the +first time You have received notice of non-compliance with this License +from such Contributor, and You become compliant prior to 30 days after +Your receipt of the notice. + +**5.2.** If You initiate litigation against any entity by asserting a patent +infringement claim (excluding declaratory judgment actions, +counter-claims, and cross-claims) alleging that a Contributor Version +directly or indirectly infringes any patent, then the rights granted to +You by any and all Contributors for the Covered Software under Section +2.1 of this License shall terminate. + +**5.3.** In the event of termination under Sections 5.1 or 5.2 above, all +end user license agreements (excluding distributors and resellers) which +have been validly granted by You or Your distributors under this License +prior to termination shall survive termination. + + +### 6. Disclaimer of Warranty + +> Covered Software is provided under this License on an “as is” +> basis, without warranty of any kind, either expressed, implied, or +> statutory, including, without limitation, warranties that the +> Covered Software is free of defects, merchantable, fit for a +> particular purpose or non-infringing. The entire risk as to the +> quality and performance of the Covered Software is with You. +> Should any Covered Software prove defective in any respect, You +> (not any Contributor) assume the cost of any necessary servicing, +> repair, or correction. This disclaimer of warranty constitutes an +> essential part of this License. No use of any Covered Software is +> authorized under this License except under this disclaimer. + +### 7. Limitation of Liability + +> Under no circumstances and under no legal theory, whether tort +> (including negligence), contract, or otherwise, shall any +> Contributor, or anyone who distributes Covered Software as +> permitted above, be liable to You for any direct, indirect, +> special, incidental, or consequential damages of any character +> including, without limitation, damages for lost profits, loss of +> goodwill, work stoppage, computer failure or malfunction, or any +> and all other commercial damages or losses, even if such party +> shall have been informed of the possibility of such damages. This +> limitation of liability shall not apply to liability for death or +> personal injury resulting from such party's negligence to the +> extent applicable law prohibits such limitation. Some +> jurisdictions do not allow the exclusion or limitation of +> incidental or consequential damages, so this exclusion and +> limitation may not apply to You. + + +### 8. Litigation + +Any litigation relating to this License may be brought only in the +courts of a jurisdiction where the defendant maintains its principal +place of business and such litigation shall be governed by laws of that +jurisdiction, without reference to its conflict-of-law provisions. +Nothing in this Section shall prevent a party's ability to bring +cross-claims or counter-claims. + + +### 9. Miscellaneous + +This License represents the complete agreement concerning the subject +matter hereof. If any provision of this License is held to be +unenforceable, such provision shall be reformed only to the extent +necessary to make it enforceable. Any law or regulation which provides +that the language of a contract shall be construed against the drafter +shall not be used to construe this License against a Contributor. + + +### 10. Versions of the License + +#### 10.1. New Versions + +Mozilla Foundation is the license steward. Except as provided in Section +10.3, no one other than the license steward has the right to modify or +publish new versions of this License. Each version will be given a +distinguishing version number. + +#### 10.2. Effect of New Versions + +You may distribute the Covered Software under the terms of the version +of the License under which You originally received the Covered Software, +or under the terms of any subsequent version published by the license +steward. + +#### 10.3. Modified Versions + +If you create software not governed by this License, and you want to +create a new license for such software, you may create and use a +modified version of this License if you rename the license and remove +any references to the name of the license steward (except to note that +such modified license differs from this License). + +#### 10.4. Distributing Source Code Form that is Incompatible With Secondary Licenses + +If You choose to distribute Source Code Form that is Incompatible With +Secondary Licenses under the terms of this version of the License, the +notice described in Exhibit B of this License must be attached. + +## Exhibit A - Source Code Form License Notice + + This Source Code Form is subject to the terms of the Mozilla Public + License, v. 2.0. If a copy of the MPL was not distributed with this + file, You can obtain one at http://mozilla.org/MPL/2.0/. + +If it is not possible or desirable to put the notice in a particular +file, then You may include the notice in a location (such as a LICENSE +file in a relevant directory) where a recipient would be likely to look +for such a notice. + +You may add additional accurate notices of copyright ownership. + +## Exhibit B - “Incompatible With Secondary Licenses” Notice + + This Source Code Form is "Incompatible With Secondary Licenses", as + defined by the Mozilla Public License, v. 2.0. -THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. diff --git a/frontend/.gitignore b/frontend/.gitignore index 0a46231..bee6ce9 100644 --- a/frontend/.gitignore +++ b/frontend/.gitignore @@ -3,3 +3,4 @@ node_modules /.svelte-kit /build /functions +.netlify diff --git a/frontend/.node-version b/frontend/.node-version index fd1bd70..2a4e4ab 100644 --- a/frontend/.node-version +++ b/frontend/.node-version @@ -1 +1 @@ -16.2.0 +16.17.0 diff --git a/frontend/.npmrc b/frontend/.npmrc index b6f27f1..e69de29 100644 --- a/frontend/.npmrc +++ b/frontend/.npmrc @@ -1 +0,0 @@ -engine-strict=true diff --git a/frontend/netlify.toml b/frontend/netlify.toml index 92e03e4..d8c33dc 100644 --- a/frontend/netlify.toml +++ b/frontend/netlify.toml @@ -1,7 +1,6 @@ [build] - ignore = "/bin/false" command = "yarn build" publish = "build/" - functions = "functions/" + [functions] node_bundler = "esbuild" diff --git a/frontend/package.json b/frontend/package.json index 39906cc..0be66b4 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -1,36 +1,35 @@ { "name": "secrets-frontend", - "license": "MPL 2.0", + "license": "MPL-2.0", "scripts": { - "dev": "svelte-kit dev", - "build": "svelte-kit build", - "preview": "svelte-kit preview", + "dev": "vite dev", + "build": "vite build", + "preview": "vite preview", + "check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json", + "check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch", "lint": "prettier --check --plugin-search-dir=. . && eslint --ignore-path .gitignore .", "format": "prettier --write --plugin-search-dir=. ." }, "devDependencies": { - "@sveltejs/adapter-netlify": "next", - "@sveltejs/kit": "next", - "@typescript-eslint/eslint-plugin": "^5.28.0", - "@typescript-eslint/parser": "^5.28.0", - "autoprefixer": "^10.4.7", - "cssnano": "^5.1.11", - "eslint": "^8.17.0", + "@sveltejs/adapter-netlify": "1.0.0-next.75", + "@sveltejs/kit": "^1.0.0-next.455", + "@typescript-eslint/eslint-plugin": "^5.36.1", + "@typescript-eslint/parser": "^5.36.1", + "autoprefixer": "^10.4.8", + "cssnano": "^5.1.13", + "eslint": "^8.23.0", "eslint-config-prettier": "^8.5.0", "eslint-plugin-svelte3": "^4.0.0", - "postcss": "^8.4.14", - "postcss-load-config": "^4.0.1", "prettier": "~2.7.1", "prettier-plugin-svelte": "^2.7.0", - "prettier-plugin-tailwindcss": "^0.1.12", + "prettier-plugin-tailwindcss": "^0.1.13", "svelte": "^3.49.0", "svelte-preprocess": "^4.10.7", - "tailwindcss": "^3.1.3", + "tailwindcss": "^3.1.8", "tslib": "^2.4.0", - "typescript": "^4.7.3" + "typescript": "^4.8.2", + "vite": "^3.0.0" }, "type": "module", - "dependencies": { - "uuid": "^8.3.2" - } + "dependencies": {} } diff --git a/frontend/postcss.config.cjs b/frontend/postcss.config.cjs index c85eff4..c0707d7 100644 --- a/frontend/postcss.config.cjs +++ b/frontend/postcss.config.cjs @@ -7,11 +7,8 @@ const dev = mode === 'development'; module.exports = { plugins: [ - // Some plugins, like postcss-nested, need to run before Tailwind tailwindcss, - // But others, like autoprefixer, need to run after autoprefixer, - !dev && cssnano({ preset: 'default' diff --git a/frontend/src/app.html b/frontend/src/app.html index 8c172db..896dde2 100644 --- a/frontend/src/app.html +++ b/frontend/src/app.html @@ -2,10 +2,11 @@ - - %svelte.head% + + + %sveltekit.head% -
%svelte.body%
+
%sveltekit.body%
diff --git a/frontend/src/lib/api.ts b/frontend/src/lib/api.ts index b4ba0c9..3af7a65 100644 --- a/frontend/src/lib/api.ts +++ b/frontend/src/lib/api.ts @@ -1,12 +1,17 @@ const API_URL = import.meta.env.VITE_API_URL; -export async function createSecret({ - secret, - expiry -}: { - secret: string; - expiry: number; -}): Promise { +export type fetchType = (info: RequestInfo, init?: RequestInit) => Promise; + +export async function createSecret( + { + secret, + expiry + }: { + secret: string; + expiry: number; + }, + fetch = globalThis.fetch +): Promise { const response = await fetch(`${API_URL}/api/secrets`, { method: 'POST', body: JSON.stringify({ secret, expiry }), @@ -21,13 +26,13 @@ export async function createSecret({ return body.room_id; } -export async function checkIfRoomExists(room: string): Promise { +export async function checkIfRoomExists(room: string, fetch = globalThis.fetch): Promise { const response = await fetch(`${API_URL}/api/secrets/${room}`, { method: 'HEAD' }); return response.status === 200; } -export async function getRoomSecret(room: string): Promise { +export async function getRoomSecret(room: string, fetch = globalThis.fetch): Promise { let response, body; try { @@ -43,7 +48,7 @@ export async function getRoomSecret(room: string): Promise { return body.secret; } -export async function deleteSecret(room: string): Promise { +export async function deleteSecret(room: string, fetch = globalThis.fetch): Promise { try { await fetch(`${API_URL}/api/secrets/${room}`, { method: 'DELETE' }); } catch (error) { @@ -51,7 +56,7 @@ export async function deleteSecret(room: string): Promise { } } -export async function getStats(): Promise<{ secretsCounter: string }> { +export async function getStats(fetch = globalThis.fetch): Promise<{ secretsCounter: string }> { try { const response = await fetch(`${API_URL}/api/stats`); const json = await response.json(); diff --git a/frontend/src/routes/__layout.svelte b/frontend/src/routes/+layout.svelte similarity index 88% rename from frontend/src/routes/__layout.svelte rename to frontend/src/routes/+layout.svelte index f669200..63036f4 100644 --- a/frontend/src/routes/__layout.svelte +++ b/frontend/src/routes/+layout.svelte @@ -1,22 +1,12 @@ - - diff --git a/frontend/src/routes/+layout.ts b/frontend/src/routes/+layout.ts new file mode 100644 index 0000000..aa7a7e6 --- /dev/null +++ b/frontend/src/routes/+layout.ts @@ -0,0 +1,8 @@ +import { getStats } from '$lib/api'; +import type { LayoutLoad } from './$types'; + +export const load: LayoutLoad = async ({ fetch }) => { + const stats = await getStats(fetch); + + return stats; +}; diff --git a/frontend/src/routes/index.svelte b/frontend/src/routes/+page.svelte similarity index 97% rename from frontend/src/routes/index.svelte rename to frontend/src/routes/+page.svelte index babfad5..1199196 100644 --- a/frontend/src/routes/index.svelte +++ b/frontend/src/routes/+page.svelte @@ -99,9 +99,9 @@ bind:value={expiry} > + + + --> diff --git a/frontend/src/routes/[room].svelte b/frontend/src/routes/[room]/+page.svelte similarity index 83% rename from frontend/src/routes/[room].svelte rename to frontend/src/routes/[room]/+page.svelte index 84a909b..a522cef 100644 --- a/frontend/src/routes/[room].svelte +++ b/frontend/src/routes/[room]/+page.svelte @@ -1,24 +1,14 @@ - -