Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly slicing arrays without proper bounds-checking can lead to potential panics in sp1-verifier. #1920

Open
2 tasks
prajwolrg opened this issue Jan 9, 2025 · 0 comments
Open
2 tasks

Directly slicing arrays without proper bounds-checking can lead to potential panics in sp1-verifier. #1920

prajwolrg opened this issue Jan 9, 2025 · 0 comments

Comments

@prajwolrg
Copy link

Component

Other (please describe)

Have you ensured that all of these are up to date?

  • SP1 SDK
  • cargo prove CLI/sp1up

What version of SP1 SDK are you on?

No response

What version of the cargo prove CLI are you on?

No response

Operating System

None

Describe the bug

On sp1-verifier, Groth16Verifier and PlonkVerifier, the verify function directly slices arrays that can cause panic. It makes sense to return InvalidData error by checking the input size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@prajwolrg