Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Filter out Sera agreements that are not grants #211

Open
jcoyne opened this issue Oct 23, 2018 · 7 comments
Open

Filter out Sera agreements that are not grants #211

jcoyne opened this issue Oct 23, 2018 · 7 comments

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Oct 23, 2018

agreementType = 'subcontract' should be filtered out.

@peetucket is this correct?

@peetucket
Copy link
Collaborator

not sure, checking with Zach. What's the downside to including (is there a question of how to map into an ontology)?

@jcoyne
Copy link
Contributor Author

jcoyne commented Oct 29, 2018

@peetucket the downside is it's more data to manage that we have no use for. It slows everything down more than necessary.

@justinlittman
Copy link
Contributor

@peetucket Can you render a verdict on this ticket?

@peetucket
Copy link
Collaborator

haven't heard back from zach, inclined to say include it for now since that seems safer than potentially excluding what could be useful data

is this configurable if it needs to changed later?

@mjgiarlo
Copy link
Member

This is not currently configurable, @peetucket

@justinlittman
Copy link
Contributor

But it is just code ...

@peetucket
Copy link
Collaborator

Yeah, just wondering what the pain level of changing is in between work cycles if it turns out to be a bad decision.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants