Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the current links to make sure they're all OK #41

Open
mstred opened this issue Aug 28, 2017 · 8 comments
Open

Review the current links to make sure they're all OK #41

mstred opened this issue Aug 28, 2017 · 8 comments

Comments

@mstred
Copy link
Contributor

mstred commented Aug 28, 2017

As noticed from @tylerecouture on PR #40, some of the links for emoji extensions were broken.
This might be happening to the other links as well, so we need to review them in order to provide a status on bad links or even to remove them.

@tylerecouture
Copy link
Contributor

tylerecouture commented Aug 28, 2017

Well... this interests me! I just learned about these plugins and want to use most of them in my project! haha. I'll post here as I test them.

Summernote-ext-highlight
First up: summernote-ext-highlight

Here a fiddle setup according to the readme:
https://jsfiddle.net/43Tesseracts/nLnngqch/

Results:

  • Firefox (55.0.2 - LinuxMint and 52.1.0 - Win10) doesn't work, gets stuck with an "insert code" popup that doesn't go away.
  • Chrome and IE, seems to work, but doesn't do any highlighting, just shows the inserted code like in a <pre>. Perhaps I need to add the prettify library? Not mentioned in the setup instructions.
  • last update, 2 years ago

@tylerecouture
Copy link
Contributor

Summernote Ace
https://github.com/wubin1989/summernote-ace-plugin

Fiddle:
https://jsfiddle.net/43Tesseracts/a3chu58e/

Results

  • Doesn't work. No input appears to "input your code" into. Firefox (55.0.2 - LinuxMint and 52.1.0 - Win10), Chrome (52.0 Mint), Edge (40.1 - Win10)
  • Last update a year ago

@tylerecouture
Copy link
Contributor

Summernote Codewrapper
https://github.com/wubin1989/summernote-ace-plugin

Fiddle:
https://jsfiddle.net/43Tesseracts/1jaoLpqd/

Results:

  • It works! =D

I'll have to use this if the other code highlighters don't get fixed, those breaks in the default code style are really annoying...

@tylerecouture
Copy link
Contributor

Perhaps you might want to create a "graveyard" section at the bottom for the old, no-longer-working extensions? As I get more familiar with this API I'd be interested in trying to resurrect some of them.

@tylerecouture
Copy link
Contributor

tylerecouture commented Aug 28, 2017

Summernote EmojiOne
https://github.com/bmironov/summernote-emojione-plugin

Fiddle:
https://jsfiddle.net/43Tesseracts/1jaoLpqd/

Results:

  • Doesn't work.
  • Emoji icon doesn't appear in toolbar.
  • TypeError: $.summernote.renderer is undefined

@tylerecouture
Copy link
Contributor

tylerecouture commented Aug 28, 2017

Summernote FontAwesome and Summernote Ext Specialchars

https://github.com/JustinEldracher/summernote-plugins

Assuming they don't work due to author's comment:

The following two plugins have not yet been updated to work with Summernote 0.7.0:

@lqez
Copy link
Member

lqez commented Aug 28, 2017

Thanks @mstred and @tylerecouture ! How could we do this better and automatically?

@DennisSuitters
Copy link
Member

I've recently transferred the StudioJunkyard repos over the DiemenDesign, so I'll fix those links and do a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants