Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug for Nonconnected Stability Regions #1

Open
Steven-Roberts opened this issue Sep 25, 2023 · 2 comments
Open

Bug for Nonconnected Stability Regions #1

Steven-Roberts opened this issue Sep 25, 2023 · 2 comments

Comments

@Steven-Roberts
Copy link
Collaborator

The stab_region function only returns the first contour detected by contourc:

c = contourc(x,y,R,[1+eps 1+eps]);

If a method has multiple disconnected regions of stability like https://github.com/LLNL/sundials/blob/54d9c4a6a73ba52c8adb010f1ed0ec66b169c7dc/doc/shared/figs/arkode/sofroniou_spaletta_erk_stab_region.png
this code would only show one region and leave out the others. I'm not sure if stability plots in the SUNDIALS docs are affected. A simple fix is to directly call contour with the x-y grid and stability functions values.

@drreynolds
Copy link
Member

Given that it's essentially impossible to leverage separate stability "islands" in an adaptive solver, I don't see any issues with displaying only the main region. However, if you'd like then I would be fine with a PR to update the script in this utilities repository, and then regenerating the stability region plots for the ARKODE documentation.

@Steven-Roberts
Copy link
Collaborator Author

I agree that the islands are not particularly useful, but it can display one island and not the primary region. I'll put this as a low priority item on my todo list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants