Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no tests exist, prompt the user if they want to generate and rerun with tests. Maybe make this a config flag to disable upfront. enabled by default #13

Open
sungchun12 opened this issue Mar 22, 2023 · 3 comments · May be fixed by #16
Assignees
Labels
enhancement New feature or request

Comments

@sungchun12
Copy link
Owner

No description provided.

@sungchun12 sungchun12 converted this from a draft issue Mar 22, 2023
@sungchun12 sungchun12 added the enhancement New feature or request label Mar 22, 2023
@xtomflo
Copy link
Collaborator

xtomflo commented Mar 23, 2023

  1. Check if tests exist before dbt build
  2. Prompt to user: Create tests? Save preference
  3. If Yes -> Auto generate tests and save
  4. If No -> Save, don't ask again

@xtomflo
Copy link
Collaborator

xtomflo commented Mar 24, 2023

@sungchun12 this proved to be a little more complicated than initially thought.
For ex. There can be a definition of the model in schema.yml, but without the tests and in that case, new model_name.yml is created which overlaps with the schema.yml.
I've got it working somewhat, but having second thoughts whether adding this complexity makes sense at this stage and whether automatic test creation is key for the v1.

Check out the connected feature branch perhaps at some point and let me know your thoughts, happy to iron it out next week as well if needed

@sungchun12
Copy link
Owner Author

Cool I can take a deeper look next week!

@sungchun12 sungchun12 linked a pull request Mar 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment