New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix all no_mangle symbols with __sunrise_libuser #491

Open

roblabla opened this issue Sep 23, 2019 · 1 comment

Labels

project-libuser type-refactoring

Member

roblabla commented Sep 23, 2019

We should prefix all our no_mangle symbols to avoid potential conflicts with user libraries. This includes:

eh_personality
panic_fmt
rust_oom
real_start
start
clean_bss
relocate_self
module_header (in global_asm)
init_main_thread
syscall_inner

roblabla added project-libuser type-refactoring labels

Contributor

kitlith commented Oct 31, 2019

lang items like eh_personality are (afaik) not required to be no_mangle, so those should be trivial to fix -- just remove no_mangle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment