New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the Pio type is duplicated between libutils and kernel #530

Open

kitlith opened this issue Oct 28, 2019 · 0 comments

Labels

project-kernel type-refactoring

Contributor

kitlith commented Oct 28, 2019

in libutils: https://github.com/sunriseos/SunriseOS/blob/32729a6464bb0292f33831922a8962fbde65cafb/libutils/src/io/pio.rs

in kernel: https://github.com/sunriseos/SunriseOS/blob/e361007f79a7ede01410c738fa90bd85ba0b63a5/kernel/src/i386/pio.rs

These files seem to be almost identical, differing in comments and a single import. We probably want to make kernel use the one in libutils.

roblabla added project-kernel type-refactoring labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment