Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufAnalyzer in Main repo causes startup error? #5

Open
brunoruviaro opened this issue Nov 17, 2020 · 2 comments
Open

BufAnalyzer in Main repo causes startup error? #5

brunoruviaro opened this issue Nov 17, 2020 · 2 comments

Comments

@brunoruviaro
Copy link

Hi,

BufAnalyzer in the old Master repository has a bug fix from Oct 15 that is not present in the same file in the Main repository. I have tried to help a couple students install HyperDisCo and ran into issues when recompiling class library. I believe new attempts to install HyperDisCo are pulling from adclib Main, thus the error?

BufAnalyzer in Master:
ff6174c

BufAnalyzer in Main (does not have the Class.initClassTree(SynthDescLib) line)
https://github.com/supercollider-quarks/adclib/blob/main/Classes/BufAnalyzer.sc

Happy to send PR but wanted to check in first if my understanding is correct. I had posted a comment here but maybe it was not the best place.

Thanks!

Bruno

@dyfer
Copy link

dyfer commented Nov 17, 2020

IIUC we might not be supporting a default branch different than master in SC currently: supercollider/supercollider#5096
We should definitely look into fixing this...

@brunoruviaro
Copy link
Author

That's strange. If I run Quarks.install("adclib") (having previously uninstalled it, all the way to manually deleting the adclib folder inside downloaded-quarks), I get this in the post window:

Quark: adclib[80ac149]

...which, as far as I can tell, is the last commit from the Main repository, not Master. To be sure, I went to the terminal and typed git branch into the newly downloaded adclib folder, and sure enough it showed *main.

So it seems SuperCollider is indeed getting the main repository, not master, when I install it using Quarks.install("adclib").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants