New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImgurMetadataProvider ちゃんとした版 #44

Open

supermomonga opened this issue Aug 28, 2017 · 4 comments

Owner

supermomonga commented Aug 28, 2017

API使う
Video(mp4,animated_gif)判定
サムネイル版画像使用

https://apidocs.imgur.com/#7d93724c-6f17-0fd2-0a51-325a006b22ca

https://api.imgur.com/models/image

Owner Author

supermomonga commented Sep 5, 2017

/a/ な URL の例： https://imgur.com/a/pFiUL

Collaborator

pgrho commented Sep 5, 2017

方針

現状のImgurMetadataProviderにAlbum・GalleryのURLパターンを追加する
ImgurMetadataProviderのインスタンス作成方法をGetInstanceメソッド経由にする(Amazon同様)
ClientIDが設定されている場合はまずAPIを使う。IDがないか403が返された場合はOGPにフォールバックする

Owner Author

supermomonga commented Sep 5, 2017

含まれるメディアが単一の場合は、（たとえAlbum, Galleryであっても）SingleImage,SingleVideo とする

Collaborator

pgrho commented Sep 6, 2017

gallery全くわからん。実態としては同IDのalbumまたはimageっぽいけどリクエスト前に区別できなきゃなー

pgrho mentioned this issue

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment