[bug] Defederating an instance doesn't fully ignore or reject follow requests from that instance

[VyrCossont]

Describe the bug with a clear and concise description of what the bug is.

Follow requests are still stored, and the follow request count includes invisible requests from defederated instances.

What's your GoToSocial Version?

main

GoToSocial Arch

No response

What happened?

A user from instance.tld sent me a follow request. I defederated from instance.tld without acting on the follow request. Now I have an empty follow request list, but a follow request count of 1. Looking at the follow_requests table shows the follow request from the defederated instance.

What you expected to happen?

As a user, I should see a follow request count of 0 if I have an empty follow request list.

I'd expect GtS to drop requests from defederated instances. If for some reason we're storing them (for example, in the case of an accidental defederation that might need to be reversed), then the follow request count should skip follow requests from those instances.

How to reproduce it?

No response

Anything else we need to know?

No response

[tsmethurst]

That's annoying indeed. Did you do the defederate by catching the instance in a wildcard match by any chance? Ie., was the domain something like poop.instance.tld and you defedded instance.tld? Just checking.

[VyrCossont]

@tobi In this case, I think it was an exact match, but unfortunately I don't have the info to be sure any more.

[NyaaaWhatsUpDoc]

could this perhaps be old data lingering? what's the date on the follow request compared to the domain block itself?

[VyrCossont]

Here's another case that causes the same symptom: if I block a user before rejecting their follow request, even if the user is not from a domain that I have defederated (m.s in this case).