Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ChordMemory doesn't stink #9

Open
2 tasks
baconpaul opened this issue Sep 19, 2023 · 8 comments
Open
2 tasks

The ChordMemory doesn't stink #9

baconpaul opened this issue Sep 19, 2023 · 8 comments

Comments

@baconpaul
Copy link
Collaborator

At least

  • design something better than our test case
  • write that
@Andreya-Autumn
Copy link
Contributor

What's it even doing currently? And/or supposed to be doing?

@baconpaul
Copy link
Collaborator Author

right now it takes your midi input and doubles it with a note 7 semitones up

@Andreya-Autumn
Copy link
Contributor

Ok gotcha. I can let this percolate on the back burner and see what pops up.

@baconpaul
Copy link
Collaborator Author

My idea for what it would be though is basic chord expansion from single key with alternate voicings and chord strategies and voice management

but really it exists primarily because I wanted a midi effect in the wrapper test suite. It could be any midi effect and still serve that purpose if you have a more useful idea

@Andreya-Autumn
Copy link
Contributor

I don't right now, but the one you have is good to be honest.

Voice management though? That's less obvious to me. What are you thinking there?

@baconpaul
Copy link
Collaborator Author

Imagine your chord is 1 3 5. You press c and hold it then press a below it. Don’t double that e.

@baconpaul
Copy link
Collaborator Author

Oh but then release the c holding the a and the e stays, and Vice versa

@Andreya-Autumn
Copy link
Contributor

Ah right, that makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants