From 165d39792453f78698bf0269c3636e021e530309 Mon Sep 17 00:00:00 2001
From: Paul Walker <paul@pwjw.com>
Date: Wed, 17 Jul 2024 14:59:27 -0400
Subject: [PATCH] Placehodler on param placement

This is a commit which just impacts Delay as I think about this
problem a tad more. The problem of course is that Delay<Config>::delay_params
requires a <Config> to actually get at the params enum, which isn't desirable,
but we need a pattern by which we can get at them without a full config
instance for things like specifying uis. Maybe

So move the ennums out of the class for now into the namespace but
I may revert this as I re-think.
---
 include/sst/effects/Delay.h | 55 ++++++++++++++++++-------------------
 1 file changed, 27 insertions(+), 28 deletions(-)

diff --git a/include/sst/effects/Delay.h b/include/sst/effects/Delay.h
index a5028ca..c2c1a00 100644
--- a/include/sst/effects/Delay.h
+++ b/include/sst/effects/Delay.h
@@ -41,38 +41,37 @@ namespace sst::effects::delay
 {
 namespace sdsp = sst::basic_blocks::dsp;
 namespace mech = sst::basic_blocks::mechanics;
+enum delay_params
+{
+    dly_time_left = 0,
+    dly_time_right,
+    dly_feedback,
+    dly_crossfeed,
+    dly_lowcut,
+    dly_highcut,
+    dly_mod_rate,
+    dly_mod_depth,
+    dly_input_channel,
+    dly_reserved, // looks like this one got removed at one point
+    dly_mix,
+    dly_width,
+
+    dly_num_params,
+};
 
-template <typename FXConfig> struct Delay : core::EffectTemplateBase<FXConfig>
+enum delay_clipping_modes
 {
-    enum delay_params
-    {
-        dly_time_left = 0,
-        dly_time_right,
-        dly_feedback,
-        dly_crossfeed,
-        dly_lowcut,
-        dly_highcut,
-        dly_mod_rate,
-        dly_mod_depth,
-        dly_input_channel,
-        dly_reserved, // looks like this one got removed at one point
-        dly_mix,
-        dly_width,
-
-        dly_num_params,
-    };
-
-    enum delay_clipping_modes
-    {
-        dly_clipping_off,
-        dly_clipping_soft,
-        dly_clipping_tanh,
-        dly_clipping_hard,
-        dly_clipping_hard18,
+    dly_clipping_off,
+    dly_clipping_soft,
+    dly_clipping_tanh,
+    dly_clipping_hard,
+    dly_clipping_hard18,
 
-        num_dly_clipping_modes,
-    };
+    num_dly_clipping_modes,
+};
 
+template <typename FXConfig> struct Delay : core::EffectTemplateBase<FXConfig>
+{
     static constexpr int numParams{dly_num_params};
     static constexpr const char *effectName{"delay"};