Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PersistedState: Adds storage event listener without regards of the type of storage #150

Closed
webJose opened this issue Dec 1, 2024 · 0 comments · Fixed by #159
Closed

PersistedState: Adds storage event listener without regards of the type of storage #150

webJose opened this issue Dec 1, 2024 · 0 comments · Fixed by #159
Labels
bug Something isn't working help wanted Open to contributions from the community.

Comments

@webJose
Copy link
Contributor

webJose commented Dec 1, 2024

Describe the bug

By looking at the code, it seems that the store will listen to 'storage' events even when the storage is not 'local'. This would then leak local storage values into session storage when the key matches.

Reproduction

Not needed?

Logs

No response

System Info

Doesn't matter

Severity

annoyance
@huntabyte huntabyte added bug Something isn't working help wanted Open to contributions from the community. labels Dec 2, 2024
@webJose webJose mentioned this issue Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Open to contributions from the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: only listen for the 'storage' event if using 'local' storage webJose/runed
2 participants
@webJose @huntabyte