Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class directives do not mark class as used #1694

Closed
Conduitry opened this issue Aug 25, 2018 · 2 comments
Closed

class directives do not mark class as used #1694

Conduitry opened this issue Aug 25, 2018 · 2 comments
Labels
bug

Comments

@Conduitry
Copy link
Member

In something like this:

<h1 class:highlight='highlight'>Hello!</h1>

<style>
	.highlight {
		background: yellow;
	}
</style>

Svelte sees the .highlight styling as unused, and removes it.
@Conduitry Conduitry added the bug label Aug 25, 2018
@Conduitry
Copy link
Member Author

I think what needs to be changed is here, so that we also accept a class:foo directive as matching the foo class.

@jacwright jacwright mentioned this issue Aug 25, 2018
Merged
@Conduitry
Copy link
Member Author

Conduitry commented Aug 28, 2018 •
edited
Loading

This was fixed with #1695 in 2.13.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Conduitry