Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Days until new versions are shown" doesn't hold to its premise #77

Open
KillyMXI opened this issue Oct 8, 2023 · 1 comment
Open

Comments

@KillyMXI
Copy link

KillyMXI commented Oct 8, 2023

image

Consider a timeline:

Version 1.0.0
              - what I see with the delay
Version 1.0.1
              - now

According to Update Tracker logic, version 1.0.0 should be good.
According to me, there is already a patched version, meaning 1.0.0 is not good and should be skipped.

How I would expect it to behave:

If the newest version is newer than mine and older than set number of days - then show it to me.

This is when I want to see the update:

Version 1.0.0
Version 1.0.1
              - what I see with the delay
(nothing here)
              - now
@swar8080
Copy link
Owner

swar8080 commented Oct 9, 2023

Thanks, that does seem like an improvement. So put another way: if the setting value is 3 days, then only show updates for a plugin if its most recent update is at 3 least days old

i'll get around to implementing this

https://github.com/swar8080/obsidian-plugin-update-tracker/blob/master/src/domain/pluginFilter.ts seems like a good spot for the change if you happen to want to implement it yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants