-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPClient.configuration should expose the configuration set #774
Comments
I agree with @weissi 's point of view. Since the configuration of |
So it is by design that it won't let you modify the global config (that'd be dangerous as it's shared) but of course it's bad that it has important global config. The fix to this is #392 . A separate bug (the one I filed here) is that AHC currently doesn't even let you read the configuration it has :|... |
In addition to allowing global configuration to be readable, I believe the global configuration for HTTPClient should not include redirectConfiguration and decompression. Alternatively, it should allow modifications to redirectConfiguration and decompression on a per-request basis. |
Agreed, I don't see a reason to have any global-only configuration. Everything that's configurable globally only means people need to migrate from FWIW, that's pretty what #392 proposes. |
For some reason, HTTPClient hides the configuration that was used to configure it from the user. We shouldn't do that.
The text was updated successfully, but these errors were encountered: