Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with phpunit 10.4.0 #608

Closed
Tofandel opened this issue Oct 6, 2023 · 6 comments
Closed

Not compatible with phpunit 10.4.0 #608

Tofandel opened this issue Oct 6, 2023 · 6 comments

Comments

@Tofandel
Copy link

Tofandel commented Oct 6, 2023

It seems the latest version of phpunit included some changes affecting panther

Exception in third-party event subscriber: Too few arguments to function Symfony\Component\Panther\ServerExtensionLegacy::executeBeforeTest(), 0 passed in /vendor/symfony/panther/src/ServerExtension.php on line 81 and exactly 1 expected

It only occurs with 10.4.0, but I'm not sure it's comming directly from phpunit, it might be coming from #589

$this->extension->executeBeforeTest();

public function executeBeforeTest(string $test): void

@shakaran
Copy link

I am getting this same error using pestphp/pest from 2.20.0 to 2.23.2 with Symfony 6.3

@janklan
Copy link
Contributor

janklan commented Oct 15, 2023

Do changes in #609 fix it for you? They did for me.

@shakaran
Copy link

shakaran commented Nov 7, 2023

Testing with:

composer require symfony/panther:dev-main

I can confirm that perfectly works.

Could you make or bump a release tag for avoid to use directly main or a specific commit?

@janklan
Copy link
Contributor

janklan commented Nov 16, 2023

That's a question for @dunglas.

@GALPR
Copy link

GALPR commented Dec 5, 2023

@dunglas Any update on this? I am running into the same issue.

@driehle
Copy link

driehle commented Dec 6, 2023

@GALPR Release 2.1.1 fixes the issues for me. See my comment here.

I think this ticket can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants