Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checklist on query methods in Axon endpoint #164

Closed
19 of 20 tasks
fjchen7 opened this issue May 2, 2023 · 7 comments
Closed
19 of 20 tasks

checklist on query methods in Axon endpoint #164

fjchen7 opened this issue May 2, 2023 · 7 comments
Assignees
Labels

Comments

@fjchen7
Copy link
Contributor

fjchen7 commented May 2, 2023

Due to AXON IBC implementation or undetermined encoding, there are some issues on query methods should be tracked and wait for later fix.

Not support

  • query_balance
  • query_all_balances
  • query_denom_trace
  • query_commitment_prefix
  • query_application_status
  • query_upgraded_client_state: not involved in main flow.
  • query_upgraded_consensus_state: not involved in main flow.
  • query_txs
  • query_packet_events
  • query_host_consensus_state
    feat: impl query_host_consensus_state for Axon #365

Not support fetch for proof

  • query_client_state
  • query_consensus_state
  • query_connection
  • query_connections
  • query_channel
  • query_packet_commitment
  • query_packet_acknowledgement
  • query_next_sequence_receive

Uncertain implementations

  • query_packet_receipt: what should be returned for bytes in response?
  • query_packet_acknowledgements and query_unreceived_acknowledgements: what sequences should be returned?

Related PRs

@ashuralyk ashuralyk changed the title checklist on query methods in AXON endpoint checklist on query methods in Axon endpoint Jul 19, 2023
@ashuralyk
Copy link
Contributor

not all of above methods should be implemented

@jjyr
Copy link
Collaborator

jjyr commented Oct 11, 2023

I have implemented the QueryHeight in this PR #347

@jjyr jjyr self-assigned this Oct 20, 2023
@jjyr
Copy link
Collaborator

jjyr commented Oct 20, 2023

记录下关于 DenomTrace 的实现

这里解释了要实现的原因,在 token 经过多次 hops 后 cosmos SDK 会 hash denom full path, 所以需要支持从 hash 查找

cosmos/cosmjs#756

已有的可以参考的实现方式是在 PacketRecv 时查找 denom 并且存储到 store 中

https://github.com/cosmos/ibc-go/blob/main/modules/apps/transfer/keeper/relay.go#L259

考虑到简化实现,我们可以直接存储到合约中。 cc @blckngm

@blckngm
Copy link
Contributor

blckngm commented Oct 20, 2023

现在实现下 ICS20TransferERC20 为收到的 denom 部署的 ERC20 tokens 的 name 是 IBC/hash(denom), 可以把反向的 mapping 也存一下 (name -> full denom) 就行?

@blckngm
Copy link
Contributor

blckngm commented Oct 20, 2023

哦,看起来 ibc-go 的 transfer 还支持直接用 ibc/hash 这样的 denom 来 transfer, 这个我们也可以考虑支持。

@blckngm
Copy link
Contributor

blckngm commented Oct 20, 2023

Event 也还是可以加一下

@jjyr
Copy link
Collaborator

jjyr commented Oct 20, 2023

这块其他的我不太清楚具体需求,我会先开始做 denomTrace 这一小块,先支持未实现的接口。

是的,只要存下来反向 mapping 就行,那就不用在 packet recv 里做了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants