New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only including 'typing' in install_requires for Python <3.5 #40

Closed

edmorley opened this issue Aug 11, 2017 · 1 comment

edmorley commented Aug 11, 2017

The typing module is available in Python 3.5 and up, so doesn't need to be installed from PyPI on those versions.

I believe the following should work:

    install_requires=[
        'typing; python_version < "3.5"',
        ...
    ],

(Similar to: https://github.com/django/channels/blob/db1b3ba951ef2c3cff6e91ed94d4115d479c0d4f/testproject/setup.py#L10)

The text was updated successfully, but these errors were encountered:

Author

edmorley commented Dec 20, 2021

Fixed by #61.

edmorley closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment