From 421b2ecbb0b273b01f4831720b6cbcab705d5e4c Mon Sep 17 00:00:00 2001 From: Tim Crawford Date: Mon, 14 Nov 2022 11:38:40 -0700 Subject: [PATCH] mb/system76/tgl-u: Disable SATA DevSlp After changing EC detection of S0ix from CPU_C10_GATE# to SLP_S0#, DevSlp blocks suspend entry. Disable it for now. Change-Id: I3ac796f1fcdd201bcfc0bff4f02dca379b5b8234 Signed-off-by: Tim Crawford --- src/mainboard/system76/tgl-u/variants/darp7/overridetree.cb | 3 ++- src/mainboard/system76/tgl-u/variants/lemp10/overridetree.cb | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mainboard/system76/tgl-u/variants/darp7/overridetree.cb b/src/mainboard/system76/tgl-u/variants/darp7/overridetree.cb index 7cf68f64e79..547fb154172 100644 --- a/src/mainboard/system76/tgl-u/variants/darp7/overridetree.cb +++ b/src/mainboard/system76/tgl-u/variants/darp7/overridetree.cb @@ -124,7 +124,8 @@ chip soc/intel/tigerlake device ref sata on # SATA1 (SSD0) register "SataPortsEnable[1]" = "1" - register "SataPortsDevSlp[1]" = "1" + # FIXME: DevSlp breaks S0ix + #register "SataPortsDevSlp[1]" = "1" register "SataPortsEnableDitoConfig[1]" = "1" register "SataSalpSupport" = "1" end diff --git a/src/mainboard/system76/tgl-u/variants/lemp10/overridetree.cb b/src/mainboard/system76/tgl-u/variants/lemp10/overridetree.cb index f2f7fcfbf76..da9d0fcce31 100644 --- a/src/mainboard/system76/tgl-u/variants/lemp10/overridetree.cb +++ b/src/mainboard/system76/tgl-u/variants/lemp10/overridetree.cb @@ -104,7 +104,8 @@ chip soc/intel/tigerlake device ref sata on # SATA1 (SSD2) register "SataPortsEnable[1]" = "1" - register "SataPortsDevSlp[1]" = "1" + # FIXME: DevSlp breaks S0ix + #register "SataPortsDevSlp[1]" = "1" register "SataPortsEnableDitoConfig[1]" = "1" register "SataSalpSupport" = "1" end