request_item_port publishes item for read accesses

[neha-pqs]

Hello,

I believe this code in monitor_base.svh is missing a condition.

tvip-axi/src/tvip_axi_monitor_base.svh

Line 35 in 9dc3483

if (item.request_ended()) begin

This works for me:
if(item.request_ended() && (item.access_type == TVIP_AXI_WRITE_ACCESS)) begin
request_item_port.write(item);
end

[taichi-ishitani]

end of requests means:

• for write access
  • transmission of address is completed and transmission of last data is completed
• for read access
  • transmission of address is completed

In addition, request_ended methods will return the above condition.

tvip-axi/src/tvip_axi_item.svh

Line 177 in 9dc3483

function bit request_ended();

Therefore, checking access type is not necessary.

[neha-pqs]

I understand what you are saying.
For read accesses, same item will be published on address_item_port and request_item_port whereas, for writes AW gets published on address_item_port, W on request_item_port.

It is now up to subscriber to filter what is coming out of those ports.
Thanks!

[taichi-ishitani]

For read accesses

This understanding is correct.

for writes

This understanding is little bit wrong.

• For AW
  • AW will be published on address_item_port
  • AW will also be published on request_item_port if W has been completed
• For W
  • W will be published on request_item_port if AW has been completed

[neha-pqs]

Yeah, that matches my understanding though I was not clear enough in writing that.
Thank you very much for the help!