Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exaustion spawn point do not let players to play at join #14

Open
mckaygerhard opened this issue Oct 30, 2021 · 0 comments · May be fixed by #16
Open

exaustion spawn point do not let players to play at join #14

mckaygerhard opened this issue Oct 30, 2021 · 0 comments · May be fixed by #16

Comments

@mckaygerhard
Copy link
Contributor

Hi again @taikedz your mod has two big feautes.. the randomized spawn and the management of spawns.. as you noted i am focused first in the first one.. and performance for big server..

now i found that when spawn is exausted .. some players cant interact.. (just received a black screen) got a big amount of that problem.. so my request feature is to have a variable to a fixed emergency spawn point.. i reviewed the code but i am so busy with the ethereal bug.. so please can you make me that favor.. i just if spawn generation is exausted (big amount of players joins) just set a spawn point fixed from config.. (with default value of course), check picture

image
@mckaygerhard mckaygerhard mentioned this issue Nov 6, 2021
Closed
mckaygerhard added a commit to minenux/rspawn that referenced this issue Nov 8, 2021
@mckaygerhard
allow players at join spawns without a spawn point yet generated due …
5fc0ac3 
…exhaustion pregens

* clarify the `spawn_anyhere`setting in readme and API definition, as pointed
  at taikedz-mt#15 (comment)
* when players join and there's no spawns, used a last resource of gen around fixed point:
  if no pregen around newpos, used the already valid random_pos, that is still valid
* this solves the bug that players cannot do anything at server join, cos pregens is exahusted
* **NOTE** spawn point still are not set, but players can spawns until a valid one is set
* removed `rspawn.kick_on_fail or attempts <= 0`, just leave `rspawn.kick_on_fail`:
  i noted never raised that condition.. i set the setting to true but never kicked the player
  i was in suspect that must be `rspawn.kick_on_fail and attempts <= 0` cos player will be
  kicked only when there's no more attempts
* i set `fixedpos.y = water_level + rspawn.search_radius` as fackback bypass of a valid air node..
  is a ugly hack, but take note that there's no more attempts here so we need to let player to just get in
  if no `rspawn.kick_on_fail` is desired.. the search radius is not a valid "altitude" but serves
  as falback if user do not defined a valid spawn point and the fixed one is still a solid node (not air)!
  This is a ugly hack of the explanation on taikedz-mt#15 (comment)
  if `spawn_anyhere` is on false, then using my code will spawn in 0,0,0 or fixed defined in minetest.conf,
  otherwise will spawn anywhere inside limits of rspawn max and min.. so admins must fine tuned that!
* Fixed closes close taikedz-mt#14
@mckaygerhard mckaygerhard linked a pull request Nov 8, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mckaygerhard